Skip to content

feat(webdriverio): simplify emulate certain device factors#13259

Merged
christian-bromann merged 3 commits intocb/setViewport-commandfrom
cb/emulate-device
Aug 6, 2024
Merged

feat(webdriverio): simplify emulate certain device factors#13259
christian-bromann merged 3 commits intocb/setViewport-commandfrom
cb/emulate-device

Conversation

@christian-bromann
Copy link
Member

Proposed changes

This command simplifies the emulation of a specific device which includes:

  • viewport size
  • device pixel ratio
  • user agent

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Aug 3, 2024
@christian-bromann christian-bromann merged commit 9456940 into cb/setViewport-command Aug 6, 2024
@christian-bromann christian-bromann deleted the cb/emulate-device branch August 6, 2024 01:23
christian-bromann added a commit that referenced this pull request Aug 6, 2024
* feat(webdriverio): new command to set viewport

* feat(webdriverio): simplify emulate certain device factors (#13259)

* feat(webdriverio): simplify emulate certain device factors

* fix import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant