Skip to content

[webdriverio-v8] Fix issue wdio log is missing in standalone mode#12703

Merged
christian-bromann merged 2 commits intowebdriverio:v8from
nguyencuongabcxyz:fix-missing-wdio-log-standalone-mode
Apr 19, 2024
Merged

[webdriverio-v8] Fix issue wdio log is missing in standalone mode#12703
christian-bromann merged 2 commits intowebdriverio:v8from
nguyencuongabcxyz:fix-missing-wdio-log-standalone-mode

Conversation

@nguyencuongabcxyz
Copy link
Copy Markdown
Contributor

@nguyencuongabcxyz nguyencuongabcxyz commented Apr 16, 2024

Proposed changes

Fix the issue where the wdio.log file is missing in the standalone mode.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@nguyencuongabcxyz nguyencuongabcxyz mentioned this pull request Apr 16, 2024
Merged
13 tasks
christian-bromann
christian-bromann approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 18, 2024
@christian-bromann christian-bromann merged commit 1e99bb5 into webdriverio:v8 Apr 19, 2024
@nguyencuongabcxyz
Copy link
Copy Markdown
Contributor Author

nguyencuongabcxyz commented Apr 22, 2024 •
edited
Loading

Hello @christian-bromann, thank you for accepting this change. May I inquire about the expected release date for this change in the v8 version? Nevermind, I saw it was released already. Thanks

JohnJoser3 pushed a commit to JohnJoser3/webdriverio-browserstack-docs that referenced this pull request May 3, 2024
@nguyencuongabcxyz @JohnJoser3
[webdriverio-v8] Fix issue wdio log is missing in standalone mode (we…
0b05f17 
…bdriverio#12703)

* Fix issue wdio log is missing in standalone mode

* Create a help method for enabling file logging, add and fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nguyencuongabcxyz @christian-bromann