Fix skip test filename#12675
Merged
christian-bromann merged 2 commits intowebdriverio:v8from Apr 18, 2024
Merged
Conversation
Member
|
A describe block is mandatory right now afaik and I do not think you can run without it. Are you able to run a "it" block that does not have a "describe" block after patching this locally? |
Contributor
Author
|
@erwinheitzman Yes I am able to run without describe block. My test file looks like below |
sauravdas1997
approved these changes
Apr 15, 2024
christian-bromann
approved these changes
Apr 15, 2024
Member
There was a problem hiding this comment.
👍
Can we raise a similar PR to the main branch?
I think technically a describe block is not needed but I am sure it will cause issues with many reporters in the WDIO ecosystem, which is why I would recommend to have them. Regardless, I think it is fine to move forward with this change.
13 tasks
|
@christian-bromann @erwinheitzman Any plans for release of v8 and v7 in near future? |
Member
|
Yes, looking into that right now. |
JohnJoser3
pushed a commit
to JohnJoser3/webdriverio-browserstack-docs
that referenced
this pull request
May 3, 2024
* fix: skip test file outside describe block * chore: null check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
If no describe block present, onSuiteStart doesn't get called. This sends filename as undefined to browserstack observability. Use specs list for filename
//: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers