Skip to content

[📖 Docs]: How to configure tests using Chromium (NOT Chrome) browser#12546

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
M-Hammad-Faisal:docss-configure-tests-using-chromium-browser
Mar 25, 2024
Merged

[📖 Docs]: How to configure tests using Chromium (NOT Chrome) browser#12546
christian-bromann merged 2 commits intowebdriverio:mainfrom
M-Hammad-Faisal:docss-configure-tests-using-chromium-browser

Conversation

@M-Hammad-Faisal
Copy link
Copy Markdown
Contributor

@M-Hammad-Faisal M-Hammad-Faisal commented Mar 23, 2024 •
edited
Loading

Proposed changes

Documentation Updated as mentioned in this issue: docs-update-for-chromium-browser

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@M-Hammad-Faisal
Copy link
Copy Markdown
Contributor Author

M-Hammad-Faisal commented Mar 23, 2024

@christian-bromann can you have a look and tell me if something is redundent or i need to update it somewhere else?

christian-bromann
christian-bromann reviewed Mar 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, once applied to the rest of the docs we should be good to go.

christian-bromann
christian-bromann approved these changes Mar 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Mar 25, 2024
@christian-bromann christian-bromann merged commit bf2ebcf into webdriverio:main Mar 25, 2024
christian-bromann pushed a commit that referenced this pull request Mar 25, 2024
@M-Hammad-Faisal @christian-bromann
[📖 Docs]: How to configure tests using Chromium (NOT Chrome) browser (#…
006a54e 
…12546)

* chromium added in Chrome browser examples

* comments resolved
@M-Hammad-Faisal M-Hammad-Faisal deleted the docss-configure-tests-using-chromium-browser branch April 27, 2024 02:06
JohnJoser3 pushed a commit to JohnJoser3/webdriverio-browserstack-docs that referenced this pull request May 3, 2024
@M-Hammad-Faisal @JohnJoser3
[📖 Docs]: How to configure tests using Chromium (NOT Chrome) browser (w…
41a370f 
…ebdriverio#12546)

* chromium added in Chrome browser examples

* comments resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Docs 📝 PRs that contain changes to the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@M-Hammad-Faisal @christian-bromann