Skip to content

[allure-report] handle case for broken status of tests with retry#12480

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
a-skindzer:broken-tests-with-retry-displayed-as-passed
Mar 15, 2024
Merged

[allure-report] handle case for broken status of tests with retry#12480
christian-bromann merged 3 commits intowebdriverio:mainfrom
a-skindzer:broken-tests-with-retry-displayed-as-passed

Conversation

@a-skindzer
Copy link
Contributor

@a-skindzer a-skindzer commented Mar 11, 2024

Fix status for first retries when the test failed with the BROKEN status:

image

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

christian-bromann
christian-bromann reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👏

Can we have a unit test for this to ensure we don't regress?

@a-skindzer
Copy link
Contributor Author

a-skindzer commented Mar 15, 2024

@christian-bromann, thanks for the comment.

I've added a few tests that reproduce retrying flow with the cucumber framework and check my changes.

Could you take a look, please?

christian-bromann
christian-bromann approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous , thanks a lot 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 15, 2024
@christian-bromann
Copy link
Member

christian-bromann commented Mar 15, 2024

@a-skindzer mind raising the same PR to the v8 branch so we can release it to the current latest version?

@christian-bromann christian-bromann merged commit 7a4f503 into webdriverio:main Mar 15, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented Mar 15, 2024

Hey a-skindzer 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@a-skindzer
Copy link
Contributor Author

a-skindzer commented Mar 15, 2024

@christian-bromann It would be great to release it for v8 as well

@christian-bromann
Copy link
Member

christian-bromann commented Mar 15, 2024

Let's do it! Mind raising a PR on the v8 branch?

@a-skindzer
Copy link
Contributor Author

a-skindzer commented Mar 15, 2024

I see 🤦
will do soon)
thanks

a-skindzer added a commit to a-skindzer/webdriverio that referenced this pull request Mar 15, 2024
@a-skindzer
[allure-report] handle case for broken status of tests with retry (we…
e335e78 
…bdriverio#12480)

* add case for broken tests with retry

* add some unit-tests to tests cucumber retrying flow

(cherry picked from commit 7a4f503)
@a-skindzer a-skindzer mentioned this pull request Mar 15, 2024
Merged
11 tasks
christian-bromann pushed a commit that referenced this pull request Mar 15, 2024
@a-skindzer
[allure-report] handle case for broken status of tests with retry (#1…
510ac62 
…2480) (#12496)

* add case for broken tests with retry

* add some unit-tests to tests cucumber retrying flow

(cherry picked from commit 7a4f503)
@a-skindzer a-skindzer deleted the broken-tests-with-retry-displayed-as-passed branch March 15, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a-skindzer @christian-bromann @wdio-bot