Skip to content

(jasmine): Bring back Jasmine assertions#10533

Merged
christian-bromann merged 7 commits intomainfrom
cb-jasmine-assertions
Jun 11, 2023
Merged

(jasmine): Bring back Jasmine assertions#10533
christian-bromann merged 7 commits intomainfrom
cb-jasmine-assertions

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jun 8, 2023

Proposed changes

It turns out that using the Jest assertion library has an impact on Jasmine users, see:

This patch brings back running assertion through Jasmine with the matchers we implemented in expect-webdriverio.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann marked this pull request as ready for review June 9, 2023 09:42
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 11, 2023
@christian-bromann christian-bromann merged commit 2fe1dcc into main Jun 11, 2023
@christian-bromann christian-bromann deleted the cb-jasmine-assertions branch June 11, 2023 20:10
This was referenced Jun 11, 2023
Closed
Closed
@ashil88
Copy link

ashil88 commented Jun 19, 2023

Hi @christian-bromann. I updated to 8.11.2 this morning and a previous passing assertion:
await expect(someString).not.toContain(subString);

is now throwing a TypeError: fn(...).negativeCompare is not a function error. Just wondering if it could be related to the changes in this PR by any chance? Couldn't see any breaking changes in the release notes...

Thanks
Ashil

@ashil88 ashil88 mentioned this pull request Jun 21, 2023
Closed
3 tasks
NoelLH added a commit to webful-ltd/passwordmaker that referenced this pull request Jul 5, 2023
@NoelLH
Pin @wdio/jasmine-framework at 8.11.0
a1b1590 
Try to work around `.not` break per:
* webdriverio/webdriverio#10606
* webdriverio/webdriverio#10533
* https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md#v8112-2023-06-12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christian-bromann @ashil88