Skip to content

update code links for browser->waitUntil#10446

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
harsha509:main
May 24, 2023
Merged

update code links for browser->waitUntil#10446
christian-bromann merged 2 commits intowebdriverio:mainfrom
harsha509:main

Conversation

@harsha509
Copy link
Member

@harsha509 harsha509 commented May 24, 2023 •
edited
Loading

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann reviewed May 24, 2023
View reviewed changes
packages/webdriverio/src/commands/browser/waitUntil.ts Outdated
* @uses utility/pause
* @example https://github.com/webdriverio/example-recipes/blob/0bfb2b8d212b627a2659b10f4449184b657e1d59/waitUntil/index.html#L3-L8
* @example https://github.com/webdriverio/example-recipes/blob/0bfb2b8d212b627a2659b10f4449184b657e1d59/waitUntil/waitUntilExample.js#L6-L14
* @example https://github.com/webdriverio/example-recipes/blob/main/waitUntil/waitUntilExample.js#L16-L24
Copy link
Member

@christian-bromann christian-bromann May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use main as branch name and rather pick a sha of your commit so we make sure the example never changes even though the example code does

christian-bromann
christian-bromann approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label May 24, 2023
@christian-bromann christian-bromann merged commit 39689e3 into webdriverio:main May 24, 2023
m4hdyar pushed a commit to m4hdyar/webdriverio-10321-allure-reporter-environment that referenced this pull request Jun 1, 2023
@harsha509
update code links for browser->waitUntil (webdriverio#10446)
5d3f874 
* update code links for browser->waitUntil

* update example link with SHA commit instead of main
christian-bromann added a commit that referenced this pull request Jun 1, 2023
@m4hdyar @harsha509
@christian-bromann @admc @dependabot @udarrr @lukefitz1 @lukefitznutrien @wdio-bot
Allure reporter add environment variables in config (#10452)
7d4f930 
* update code links for browser->waitUntil (#10446)

* update code links for browser->waitUntil

* update example link with SHA commit instead of main

* New Crowdin updates (#10444)

* New translations Donate.md (Bulgarian)

* New translations Element.md (Polish)

* New translations Donate.md (Bulgarian)

* New translations Element.md (Polish)

* New translations Donate.md (Bulgarian)

* New translations Materials.md (Bulgarian)

* New translations code.json (Bulgarian)

* Recommend the runme extension for vs coders (#10449)

* tabs vs spaces

* Bump @typescript-eslint/parser from 5.59.6 to 5.59.7 (#10456)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.59.6 to 5.59.7.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.59.7/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @typescript-eslint/utils from 5.59.6 to 5.59.7 (#10457)

Bumps [@typescript-eslint/utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/utils) from 5.59.6 to 5.59.7.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/utils/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.59.7/packages/utils)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/utils"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump devtools-protocol from 0.0.1146845 to 0.0.1149535 (#10458)

Bumps [devtools-protocol](https://github.com/ChromeDevTools/devtools-protocol) from 0.0.1146845 to 0.0.1149535.
- [Changelog](https://github.com/ChromeDevTools/devtools-protocol/blob/master/changelog.md)
- [Commits](ChromeDevTools/devtools-protocol@v0.0.1146845...v0.0.1149535)

---
updated-dependencies:
- dependency-name: devtools-protocol
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump aws-sdk from 2.1381.0 to 2.1386.0 (#10461)

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1381.0 to 2.1386.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Commits](aws/aws-sdk-js@v2.1381.0...v2.1386.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @types/jasmine from 4.3.1 to 4.3.2 (#10460)

Bumps [@types/jasmine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jasmine) from 4.3.1 to 4.3.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jasmine)

---
updated-dependencies:
- dependency-name: "@types/jasmine"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @sveltejs/vite-plugin-svelte from 2.3.0 to 2.4.1 (#10465)

Bumps [@sveltejs/vite-plugin-svelte](https://github.com/sveltejs/vite-plugin-svelte/tree/HEAD/packages/vite-plugin-svelte) from 2.3.0 to 2.4.1.
- [Release notes](https://github.com/sveltejs/vite-plugin-svelte/releases)
- [Changelog](https://github.com/sveltejs/vite-plugin-svelte/blob/main/packages/vite-plugin-svelte/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/vite-plugin-svelte/commits/@sveltejs/vite-plugin-svelte@2.4.1/packages/vite-plugin-svelte)

---
updated-dependencies:
- dependency-name: "@sveltejs/vite-plugin-svelte"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @vitest/coverage-c8 from 0.30.1 to 0.31.1 (#10464)

Bumps [@vitest/coverage-c8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-c8) from 0.30.1 to 0.31.1.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v0.31.1/packages/coverage-c8)

---
updated-dependencies:
- dependency-name: "@vitest/coverage-c8"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump strip-ansi from 6.0.1 to 7.1.0 (#10463)

Bumps [strip-ansi](https://github.com/chalk/strip-ansi) from 6.0.1 to 7.1.0.
- [Release notes](https://github.com/chalk/strip-ansi/releases)
- [Commits](chalk/strip-ansi@v6.0.1...v7.1.0)

---
updated-dependencies:
- dependency-name: strip-ansi
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dependabot/fetch-metadata from 1.4.0 to 1.5.1 (#10455)

Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.4.0 to 1.5.1.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](dependabot/fetch-metadata@v1.4.0...v1.5.1)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* added new service to services list is named 'wdio-robonut-service' (#10454)

* added new service have been named 'wdio-robonut-service'

* fixed title mistake

* added wdio-robonut-service to cli constants external section

* New Crowdin updates (#10451)

* New translations options.json (Bulgarian)

* New translations current.json (Bulgarian)

* New translations current.json (Bulgarian)

* New translations current.json (Bulgarian)

* New translations code.json (Bulgarian)

* New translations current.json (Bulgarian)

* New translations current.json (Bulgarian)

* New translations footer.json (Bulgarian)

* New translations navbar.json (Bulgarian)

* New translations code.json (Bulgarian)

* New translations current.json (Bulgarian)

* New translations Browser.md (Bulgarian)

* New translations Team.md (Bulgarian)

* New translations code.json (Bulgarian)

* New translations code.json (Bulgarian)

* New translations Environment.md (Polish)

* New translations Environment.md (Polish)

* New translations Environment.md (Polish)

* New translations Browser.md (Polish)

* New translations Globals.md (Polish)

* New translations Mock.md (Polish)

* New translations Mock.md (Polish)

* exporting the addTag method so it can be used (#10477)

Co-authored-by: Luke Fitzgerald <luke.fitzgerald@nutrien.com>

* New Crowdin updates (#10478)

* New translations Modules.md (Polish)

* New translations Modules.md (Polish)

* Bump got from 12.6.1 to 13.0.0 (#10462)

Bumps [got](https://github.com/sindresorhus/got) from 12.6.1 to 13.0.0.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](sindresorhus/got@v12.6.1...v13.0.0)

---
updated-dependencies:
- dependency-name: got
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert got from v13 to v12.6.0 due to type issues
ref https://github.com/sindresorhus/got/issues/2267

* adjust test coverage

* v8.10.6

* Remove addEnvironment

* Setting the environment variables in the config

* Adjust allure tests because of environment changes

* Add environment changes of allure to documentation

* Add addEnvironment function again as a deprecated function

* Update packages/wdio-allure-reporter/src/common/api.ts

Change the deprecation message

Co-authored-by: Christian Bromann <git@bromann.dev>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Adam Christian <adam.christian@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siarhei Kliushnikau <77188735+udarrr@users.noreply.github.com>
Co-authored-by: lukefitz1 <lukefitz1@gmail.com>
Co-authored-by: Luke Fitzgerald <luke.fitzgerald@nutrien.com>
Co-authored-by: WebdriverIO Release Bot <bot@webdriver.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Docs 📝 PRs that contain changes to the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harsha509 @christian-bromann