devtools: Honor acceptInsecureCerts and ignoreHTTPSErrors settings#10329
Conversation
|
@christian-bromann Maybe we should cleanup this logic or at least align implementation.
For this use case we are going to have two settings that achieve the same thing: Can you think of more flags to pass to Webkit/Blink engines when we |
christian-bromann
left a comment
There was a problem hiding this comment.
Can you think of more flags to pass to Webkit/Blink engines when we ignoreHTTPSErrors, other than just --ignore-certificate-errors?
Not really. I am not too familiar with all flags.
|
@christian-bromann how come this was left out of the changelog? |
|
I missed to label this PR correctly, sorry about that, let me add it manually. |
@christian-bromann I see you added it thank you, but there's extra erroneous information unrelated to the feature, has nothing to do with the browserstack-service #10329 [browserstack-service] devtools: Honor acceptInsecureCerts and ignoreHTTPSErrors settings (@ nextlevelbeard) |
|
Ah sorry, copy&paste mistake , let me update |
Proposed changes
Testing against local web development servers often require automation to ignore self-signed certificates. There is a W3C spec capability (
acceptInsecureCerts) that allows us to proceed in these cases. However the automation protocoldevtoolswas not respecting this capability and passing the need flags to the browser launcher routines.We already have the devtools option
ignoreHTTPSErrorsthat can be defined in thewdio:devtoolsOptionscapability. This seems to only have effect for Firefox.For Webkit/Blink based browsers, it is necessary to pass the (chrome)flag
--ignore-certificate-errors.There is some code duplication due to separated logic of launching Chrome and Edge.
fixes #10328
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers