Update to correct exports for CJS#10199
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Apr 17, 2023
Merged
Conversation
Contributor
Author
|
@christian-bromann So I just tested the wdio/cli CJS setup that I made last week... and I did not do the exports correct. This should fix that issue. Sorry about that. |
Member
christian-bromann
left a comment
There was a problem hiding this comment.
In order to prevent regression on this again, can we add a test to https://github.com/webdriverio/webdriverio/tree/main/e2e/interop where files are loaded in CJS context? Just import Launcher and run and see if they are from type function
3 tasks
christian-bromann
approved these changes
Apr 17, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
I will go ahead and add this interop test myself as I am wanting to run a new release.
Thanks for the fix 🎉
christian-bromann
added a commit
that referenced
this pull request
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #10198
Types of changes
Checklist
Further comments
Update to using correct exports for CJS.
Reviewers: @webdriverio/project-committers