Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

CODEOWNERS update#7350

Merged
jdevcs merged 1 commit into4.xfrom
junaid/updatemembers
Oct 24, 2024
Merged

CODEOWNERS update#7350
jdevcs merged 1 commit into4.xfrom
junaid/updatemembers

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Oct 23, 2024

Description

CODEOWNERS update

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions
Copy link

github-actions bot commented Oct 23, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 642.3 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 622.77 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

github-actions[bot]
github-actions bot reviewed Oct 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: f9878e5 Previous: 3687070 Ratio
processingTx 22952 ops/sec (±6.41%) 22856 ops/sec (±6.62%) 1.00
processingContractDeploy 37672 ops/sec (±10.04%) 37573 ops/sec (±8.57%) 1.00
processingContractMethodSend 15512 ops/sec (±8.31%) 15453 ops/sec (±7.92%) 1.00
processingContractMethodCall 28189 ops/sec (±5.93%) 27091 ops/sec (±7.83%) 0.96
abiEncode 44589 ops/sec (±6.99%) 42669 ops/sec (±7.08%) 0.96
abiDecode 29827 ops/sec (±7.72%) 30350 ops/sec (±6.23%) 1.02
sign 1521 ops/sec (±2.93%) 1520 ops/sec (±3.42%) 1.00
verify 371 ops/sec (±0.83%) 362 ops/sec (±0.69%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (3687070) to head (f9878e5).
Report is 3 commits behind head on 4.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##              4.x    #7350   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         217      217           
  Lines        8487     8487           
  Branches     2343     2343           
=======================================
  Hits         8021     8021           
  Misses        466      466
Flag Coverage Δ
UnitTests 94.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdevcs jdevcs merged commit 0681f97 into 4.x Oct 24, 2024
@jdevcs jdevcs deleted the junaid/updatemembers branch October 24, 2024 08:30
MRLab12 pushed a commit to MRLab12/web3.js that referenced this pull request Oct 30, 2024
@jdevcs @MRLab12
update (web3#7350)
c446cd8
@luu-alex luu-alex mentioned this pull request Nov 6, 2024
Merged
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@avkos avkos Awaiting requested review from avkos

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba

2 more reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@luu-alex luu-alex luu-alex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jdevcs @luu-alex