This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix a docs typo in subscribe migration guide#7325
Closed
Conversation
Contributor
|
cc: @danforbes |
Contributor
|
Thank you for spotting this error @Joro97. In order to protect against airdrop farming, we have a policy against merging pull requests that only include very small typo changes. I have folded your corrections into an existing documentation PR that I am working on - #7334. Please feel free to refer to the Issues labeled "Good First Issue" if you're looking for ways to contribute to Web3.js. |
danforbes
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Intermediate dApp Guide Closes #7038 * Fix Typo Closes #7324 Replaces #7325 * Update docs/docs/guides/07_dapps/intermediate-dapp.md Co-authored-by: Kris <605420+krzysu@users.noreply.github.com> * Small Changes Based on Suggestion from @krzysu --------- Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes 7324 Fixing a small typo in subscribe migration guide.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.