This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Merged
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 85a0f06 | Previous: 3687070 | Ratio |
|---|---|---|---|
processingTx |
22299 ops/sec (±8.22%) |
22856 ops/sec (±6.62%) |
1.02 |
processingContractDeploy |
40183 ops/sec (±7.37%) |
37573 ops/sec (±8.57%) |
0.94 |
processingContractMethodSend |
15965 ops/sec (±7.05%) |
15453 ops/sec (±7.92%) |
0.97 |
processingContractMethodCall |
27634 ops/sec (±6.25%) |
27091 ops/sec (±7.83%) |
0.98 |
abiEncode |
43396 ops/sec (±7.65%) |
42669 ops/sec (±7.08%) |
0.98 |
abiDecode |
30028 ops/sec (±8.76%) |
30350 ops/sec (±6.23%) |
1.01 |
sign |
1537 ops/sec (±3.59%) |
1520 ops/sec (±3.42%) |
0.99 |
verify |
369 ops/sec (±0.56%) |
362 ops/sec (±0.69%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7322 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 217 217
Lines 8487 8487
Branches 2343 2343
=======================================
Hits 8021 8021
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more. |
danforbes
approved these changes
Oct 22, 2024
krzysu
approved these changes
Oct 22, 2024
jdevcs
reviewed
Oct 23, 2024
jdevcs
reviewed
Oct 23, 2024
jdevcs
approved these changes
Oct 23, 2024
MRLab12
pushed a commit
to MRLab12/web3.js
that referenced
this pull request
Oct 30, 2024
* init * finished * add unit test * add changelog * Update CHANGELOG.md * Update web3_provider_publicnode.ts * fix * Update web3_provider_publicnode.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6973
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.