Skip to content

Adding Intel XHR timeout tests.#91

Merged
hallvors merged 1 commit intoweb-platform-tests:masterfrom
tmpsantos:new_xhr_tests
May 21, 2013
Merged

Adding Intel XHR timeout tests.#91
hallvors merged 1 commit intoweb-platform-tests:masterfrom
tmpsantos:new_xhr_tests

Conversation

@tmpsantos
Copy link

A set of tests ensuring correct behavior of the XHR timeout property and related events. Adapted from Alex Vincent's tests used in Firefox (with friendly permission).

Signed-off-by: Dominik Röttsches dominik.rottsches@intel.com

@odinho
Copy link
Contributor

odinho commented Apr 18, 2013

Hey, awesome with more XHR tests!

I hope someone can take a look pretty soon. I wanted to tell you that at least one blocker is the place you've put the files. We do not use that old folder based submission system anymore. This PR is the submission. Sorry about that but we just did the transition a short while ago.

So if you can move them to root where they belong it'd instantly look better :)

@tmpsantos
Copy link
Author

Hi Velmont,

I just pushed a new version of the patch using the new directory structure.

Thanks for commenting.

@jgraham
Copy link
Contributor

jgraham commented May 16, 2013

w3c-test:mirror

@hallvors
Copy link
Contributor

Just a status update: I've looked at the tests, suggested some changes, some discussion on mail and IRC has taken place.

@jgraham
Copy link
Contributor

jgraham commented May 16, 2013

w3c-test:mirror

Signed-off-by: Dominik Röttsches <dominik.rottsches@intel.com>
@drott
Copy link
Contributor

drott commented May 17, 2013

Review comments addressed.

I'd prefer if the code that matters for the test was in the file that "is" the test itself. (In this case that might mean some more code duplication, so I guess it's a YMMV thing.) I assume much

Refactored so that test definitions are in individual .js files and imported for document and worker case. Simplified individual test files from an onload method to a bottom-of-page inline script.

PS AbortedRequest.prototype.startXHR() method doesn't need both a "me" and a "_this" variable.--

Removed me var.

Added missing *-overrides.html files.

A running demo of these tests can be found here: http://w3ctests.roettsch.es/XMLHttpRequest/

@jgraham
Copy link
Contributor

jgraham commented May 17, 2013

hallvors pushed a commit that referenced this pull request May 21, 2013
Adding Intel XHR timeout tests.
@hallvors hallvors merged commit 4ee5b70 into web-platform-tests:master May 21, 2013
@hallvors
Copy link
Contributor

Thanks for the rewrite!

jugglinmike pushed a commit to bocoup/wpt that referenced this pull request Apr 11, 2017
…-fix

Point readme to latest docs location.
jgraham pushed a commit that referenced this pull request Apr 13, 2017
Make it possible to run tests in tox; use tox on Travis
jgraham pushed a commit that referenced this pull request Apr 13, 2017
Run tests on Travis CI and make it possible to run tox and have them run
jgraham added a commit that referenced this pull request Apr 21, 2017
Support setting prefs in wptrunner via ini files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants