Add tests that check addHitRegion throws NotSupportedError#851
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/1239 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
w3c-test:mirror |
|
@cabanier can you please review this if/when you have time? https://critic.hoppipolla.co.uk/r/1239 |
Add tests that check addHitRegion throws NotSupportedError
|
@takenspc I went ahead and merged this but ideally the test should go in 2dcontext/tools/tests2d.yaml and the actual HTML test file should be generated from that. Do you have time to take a shot at moving this to 2dcontext/tools/tests2d.yaml? If not, let me know and I'll do it. |
|
@takenspc Actually, after looking at this again, I can see it was premature of me to merge it. Will add some more comments over on https://critic.hoppipolla.co.uk/r/1239. After that, if you want to make the changes, please either open a new PR for this, or let me know and I'll open one myself. |
addHitRegion throws NotSupportedError when the path has no pixels.
And there are few methods on Canvas2D Context which render shapes and not affect the current path.
These tests check combination of addHitRegion and such methods.
I tested these with Mozilla Firefox nightly 31.0a1 (2014-04-08).