HTML: Update IDL for focus(options)#7915
Merged
Merged
Conversation
Build PASSEDStarted: 2017-10-26 16:50:54 Failing Jobs
View more information about this build on: |
foolip
approved these changes
Oct 20, 2017
domenic
approved these changes
Oct 26, 2017
f9c7927 to
de02311
Compare
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 28, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec proposal: whatwg/html#2787 (comment) tests: #7915 #7917 Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI Bug:734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 30, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec proposal: whatwg/html#2787 (comment) tests: #7915 #7917 Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI Bug:734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 30, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis tests: #7915 #7917 Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI Bug:734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 2, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis tests: #7915 #7917 Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI Bug:734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 8, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis web-platform-tests: #7915 #7917 Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY Bug:734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 9, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis web-platform-tests: #7915 #7917 Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY Bug: 734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4 Reviewed-on: https://chromium-review.googlesource.com/731225 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#515040}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 9, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis web-platform-tests: #7915 #7917 Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY Bug: 734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4 Reviewed-on: https://chromium-review.googlesource.com/731225 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#515040}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Nov 9, 2017
Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis web-platform-tests: web-platform-tests/wpt#7915 web-platform-tests/wpt#7917 Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY Bug: 734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4 Reviewed-on: https://chromium-review.googlesource.com/731225 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#515040}
flowergom
pushed a commit
to webosose/chromium53
that referenced
this pull request
Sep 20, 2018
:Release Notes: Enable prevent scrolling in Element.focus() :Detailed Notes: From upstream https://chromium-review.googlesource.com/c/chromium/src/+/731225/5 https://www.chromestatus.com/feature/5745122025144320 Enable prevent scrolling in Element.focus() Implement Focusptions for focus() under a experimental flag. FocusOptions has a boolean preventScroll (default false) to prevent scrolling. spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis web-platform-tests: web-platform-tests/wpt#7915 web-platform-tests/wpt#7917 Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY Bug: 734166 Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4 Reviewed-on: https://chromium-review.googlesource.com/731225 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#515040} With two main differences from upstream patch: - Removed "[RuntimeEnabled=FocusOptions]" from FocusOptions.idl. - Added '<(blink_core_output_dir)/html/FocusOptions.cpp' and '<(blink_core_output_dir)/html/FocusOptions.h' to core.gypi as otherwise I was getting a link error when building libcbe. :Testing Performed: Verified using sample hosted at: http://<ip>:<port>/samplesForTesting/scrollerNative-5532/ :QA Notes: :Issues Addressed: [PLAT-64240] HTMLElement.focus preventScroll option to resolve stutter while scrolling Change-Id: Ibcc0111e6b98b137bdfd693683a13a343c7ea372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per whatwg/html#2787
cc @jihyerish @anawhj