Conversation
Testing first paragraph of musts in 2.8.2.3
Changed value to null from undefined.
There was a problem hiding this comment.
Wrap this all in a test() instead.
Removed mutation events (split out into other file with async on mutation observers?) and made all other indicated fixes.
Tests the namedItem() method on an HTMLOptionsCollection for correct return type/value on single match, no match, and multiple match cases.
|
These files aren't in the correct directory. |
|
Sorry. What is the corrrect directory? I'll move them. |
|
Somewhere within the html directory. |
Moved from common/ to semantics/forms/the-select-element/ per feedback from tobie. Tests should now satisfy ms2ger's code quality suggestions and tobie's placement suggestions.
|
Changed directory to more appropriate location. |
|
Critic review: https://critic.hoppipolla.co.uk/r/583 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Added some comments on critic. |
|
@grbulm there are review comments waiting for your responses over at https://critic.hoppipolla.co.uk/r/583 For example, https://critic.hoppipolla.co.uk/showcomment?chain=1670 |
|
@jgraham no responses from @grbulm on this in many months. I suggest we either close or you wrap it up yourself. |
|
?Sorry, didn't get the May message. On the January message, if I did, I might have thought getting a link to some site I'd never heard of (hoppipolla.co.uk) 9 months after the last communication was suspect and canned it. Tomorrow's a national holiday, yesterday was "bring your kids to work day," and I've got a lot to catch up for the day job. Will look at and make edits next week. From: Michael[tm] Smith notifications@github.com @jgrahamhttps://github.com/jgraham no responses from @grbulmhttps://github.com/grbulm on this in many months. I suggest we either close or you wrap it up yourself. Reply to this email directly or view it on GitHubhttps://github.com//pull/76#issuecomment-47886859. |
|
@grbulm sounds good—thanks for the update. Will keep this open |
|
Rebased and addressed comments in #1563. Thanks for the contribution, @grbulm! |
Update WebIDL submodule to latest release.
Testing musts in first paragraph of HTML5 2.8.2.3