Add a lint for LayoutTests APIs eventSender/testRunner/window.internals#7544
Merged
Add a lint for LayoutTests APIs eventSender/testRunner/window.internals#7544
Conversation
Build PASSEDStarted: 2017-10-02 18:41:07 View more information about this build on: |
15edc73 to
4e01867
Compare
Ms2ger
approved these changes
Oct 2, 2017
| check_errors(errors) | ||
|
|
||
| if kind == "python": | ||
| assert errors == [("PARSE-FAILED", "Unable to parse file", filename, 1)] |
Contributor
There was a problem hiding this comment.
Kinda silly to run these checks on python too, but that's all my doing, so I can't complain.
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 2, 2017
See #7544. Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 3, 2017
See #7544. TBR: mkwst@chromium.org Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 4, 2017
See #7544. TBR: mkwst@chromium.org Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07 Reviewed-on: https://chromium-review.googlesource.com/696084 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506375}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 4, 2017
See #7544. TBR: mkwst@chromium.org Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07 Reviewed-on: https://chromium-review.googlesource.com/696084 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506375}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Oct 5, 2017
See web-platform-tests/wpt#7544. TBR: mkwst@chromium.org Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07 Reviewed-on: https://chromium-review.googlesource.com/696084 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506375}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Oct 6, 2017
Most notably we would like to have this new lint for Blink internal APIs in external/wpt: web-platform-tests/wpt#7544 Bug: 749879 Change-Id: Ia1b2a1832b53e98d0c3204948a003a88d24dfff0 Reviewed-on: https://chromium-review.googlesource.com/702534 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506781}
jakearchibald
pushed a commit
to jakearchibald/web-platform-tests
that referenced
this pull request
Nov 16, 2017
See web-platform-tests#7544. TBR: mkwst@chromium.org Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07 Reviewed-on: https://chromium-review.googlesource.com/696084 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506375}
nareix
pushed a commit
to nareix/webrtc.third_party
that referenced
this pull request
Mar 5, 2018
See web-platform-tests/wpt#7544. TBR: mkwst@chromium.org Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07 Reviewed-on: https://chromium-review.googlesource.com/696084 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#506375} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 32d1d5b79526ed44505e0860b6e93e3a37f136af
nareix
pushed a commit
to nareix/webrtc.third_party
that referenced
this pull request
Mar 5, 2018
Most notably we would like to have this new lint for Blink internal APIs in external/wpt: web-platform-tests/wpt#7544 Bug: 749879 Change-Id: Ia1b2a1832b53e98d0c3204948a003a88d24dfff0 Reviewed-on: https://chromium-review.googlesource.com/702534 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#506781} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 8f618c88a419d8fb68853e11c08aa0103c8ba338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7541.
This change is