Remove vendor prefix support in webaudio/; assert their absense#7508
Merged
Remove vendor prefix support in webaudio/; assert their absense#7508
Conversation
See the many other historical.html in the repo for precedence. Of course, if they are added to some standard, then it would be appropriate to instead assert that they exist. (Prefixes are not the problem, lack of standardization is.)
foolip
added a commit
that referenced
this pull request
Sep 27, 2017
Tests should follow what the specs say, and unless the specs define the prefixed APIs [1] the right this is to assume the per-spec names and to add historical.html tests asserting the absense of prefixed APIs that have existed somewhere. Based on web-confluence.appspot.com, navigator.vibrate was never prefixed, but mozSrcObject is in Firefox. A test is added for mozSrcObject, and the others APIs are already covered by existing tests, or one of these: #7507 #7508 [1] https://dom.spec.whatwg.org/#dom-element-webkitmatchesselector https://url.spec.whatwg.org/#url-class and others
Build PASSEDStarted: 2017-09-27 13:51:49 View more information about this build on: |
Member
Author
|
@rtoy, can you review? |
padenot
approved these changes
Sep 29, 2017
Contributor
padenot
left a comment
There was a problem hiding this comment.
Looks fine, thanks!
Sorry for the delay here.
foolip
added a commit
that referenced
this pull request
Sep 29, 2017
Tests should follow what the specs say, and unless the specs define the prefixed APIs [1] the right this is to assume the per-spec names and to add historical.html tests asserting the absense of prefixed APIs that have existed somewhere. Based on web-confluence.appspot.com, navigator.vibrate was never prefixed, but mozSrcObject is in Firefox. A test is added for mozSrcObject, and the others APIs are already covered by existing tests, or one of these: #7507 #7508 [1] https://dom.spec.whatwg.org/#dom-element-webkitmatchesselector https://url.spec.whatwg.org/#url-class and others
jakearchibald
pushed a commit
to jakearchibald/web-platform-tests
that referenced
this pull request
Nov 16, 2017
Tests should follow what the specs say, and unless the specs define the prefixed APIs [1] the right this is to assume the per-spec names and to add historical.html tests asserting the absense of prefixed APIs that have existed somewhere. Based on web-confluence.appspot.com, navigator.vibrate was never prefixed, but mozSrcObject is in Firefox. A test is added for mozSrcObject, and the others APIs are already covered by existing tests, or one of these: web-platform-tests#7507 web-platform-tests#7508 [1] https://dom.spec.whatwg.org/#dom-element-webkitmatchesselector https://url.spec.whatwg.org/#url-class and others
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the many other historical.html in the repo for precedence. Of
course, if they are added to some standard, then it would be
appropriate to instead assert that they exist. (Prefixes are not the
problem, lack of standardization is.)