manual test for PaymentResponse.shippingAddress attr#6952
Merged
marcoscaceres merged 4 commits intomasterfrom Aug 21, 2017
Merged
manual test for PaymentResponse.shippingAddress attr#6952marcoscaceres merged 4 commits intomasterfrom
marcoscaceres merged 4 commits intomasterfrom
Conversation
edenchuang
requested changes
Aug 21, 2017
| assert_equals(response.requestId, request.id, `Expected ids to match`); | ||
| const { shippingAddress: addr } = request; | ||
| assert_true( | ||
| addr.addressLine instanceof PaymentAddress, |
Contributor
There was a problem hiding this comment.
I guess it should be "addr instanceof PaymentAddress", not addr.addressLine.
| </li> | ||
| <li> | ||
| <button onclick="runManualTest(this, {requestShipping: true}, { shippingAddress: 'pass' }).then(done)"> | ||
| If the requestShipping member is true, then shippingAddress will be the full and final shipping address is "wpt street" in "Kabul, Afghanistan", zip/postal code 1001. |
Contributor
There was a problem hiding this comment.
s/wpt street/1 wpt street
Build PASSEDStarted: 2017-08-21 08:14:59 View more information about this build on: |
Build PASSEDStarted: 2017-08-21 07:27:27 View more information about this build on: |
1 similar comment
Build PASSEDStarted: 2017-08-21 07:27:27 View more information about this build on: |
rachelandrew
pushed a commit
to rachelandrew/web-platform-tests
that referenced
this pull request
Nov 8, 2017
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Remove nesting :has() cases from the existing wpt tests and add a tentative wpt test to check disallowing nesting :has() inside :has(). w3c/csswg-drafts#6952 (comment) Bug: 669058, 1334631 Change-Id: I549ee9d5b1ca17d22f7f8982d0e9ff96df6937df
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Remove nesting :has() cases from the existing wpt tests and add a tentative wpt test to check disallowing nesting :has() inside :has(). w3c/csswg-drafts#6952 (comment) Bug: 669058, 1334631 Change-Id: I549ee9d5b1ca17d22f7f8982d0e9ff96df6937df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697654 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1013385}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Remove nesting :has() cases from the existing wpt tests and add a tentative wpt test to check disallowing nesting :has() inside :has(). w3c/csswg-drafts#6952 (comment) Bug: 669058, 1334631 Change-Id: I549ee9d5b1ca17d22f7f8982d0e9ff96df6937df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697654 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1013385}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714637 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016121}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714637 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016121}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.