Update tests for fullscreen event targets (element or document) by foolip · Pull Request #6017 · web-platform-tests/wpt

foolip · 2017-05-22T09:52:43Z

ghost · 2017-05-22T10:12:27Z

Firefox (nightly)

Testing web-platform-tests at revision 1cb8ea1
Using browser at version BuildID 20170531100318; SourceStamp 7b8937970f9ca85db88cb2496f2112175fd847c8
Starting 10 test iterations
All results were stable

All results

2 tests ran

/fullscreen/api/element-request-fullscreen-not-allowed.html

Subtest	Results	Messages
	OK
`Element#requestFullscreen() when not allowed to request fullscreen`	FAIL	`assert_equals: event.target expected Element node <div id="log"></div> but got Document node with 2 children`

/fullscreen/interfaces.html

Subtest	Results	Messages
	OK
`Test driver`	PASS
`Document interface: attribute fullscreenEnabled`	PASS
`Document interface: attribute fullscreen`	PASS
`Document interface: operation exitFullscreen()`	FAIL	`assert_unreached: Throws "TypeError: 'exitFullscreen' called on an object that does not implement interface Document." instead of rejecting promise Reached unreachable code`
`Document interface: attribute onfullscreenchange`	PASS
`Document interface: attribute onfullscreenerror`	PASS
`Document interface: attribute fullscreenElement`	PASS
`Document must be primary interface of new Document`	PASS
`Stringification of new Document`	PASS
`Document interface: new Document must inherit property "fullscreenEnabled" with the proper type (29)`	PASS
`Document interface: new Document must inherit property "fullscreen" with the proper type (30)`	PASS
`Document interface: new Document must inherit property "exitFullscreen" with the proper type (31)`	PASS
`Document interface: new Document must inherit property "onfullscreenchange" with the proper type (32)`	PASS
`Document interface: new Document must inherit property "onfullscreenerror" with the proper type (33)`	PASS
`Document interface: new Document must inherit property "fullscreenElement" with the proper type (35)`	PASS
`ShadowRoot interface: attribute fullscreenElement`	FAIL	`assert_true: The prototype object must have a property "fullscreenElement" expected true got false`
`Element interface: operation requestFullscreen()`	FAIL	`assert_unreached: Throws "TypeError: 'requestFullscreen' called on an object that does not implement interface Element." instead of rejecting promise Reached unreachable code`
`Element interface: attribute onfullscreenchange`	FAIL	`assert_true: The prototype object must have a property "onfullscreenchange" expected true got false`
`Element interface: attribute onfullscreenerror`	FAIL	`assert_true: The prototype object must have a property "onfullscreenerror" expected true got false`
`Element must be primary interface of document.createElementNS(null, "test")`	PASS
`Stringification of document.createElementNS(null, "test")`	PASS
`Element interface: document.createElementNS(null, "test") must inherit property "requestFullscreen" with the proper type (34)`	PASS
`Element interface: document.createElementNS(null, "test") must inherit property "onfullscreenchange" with the proper type (35)`	FAIL	`assert_inherits: property "onfullscreenchange" not found in prototype chain`
`Element interface: document.createElementNS(null, "test") must inherit property "onfullscreenerror" with the proper type (36)`	FAIL	`assert_inherits: property "onfullscreenerror" not found in prototype chain`

ghost · 2017-05-22T10:12:27Z

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 2e09fc8
Using browser at version BuildID 20170521100319; SourceStamp 5b74bbf20e803e299790d266fc6ebf5d53b7a1b7
Starting 10 test iterations
All results were stable

All results

1 test ran

/fullscreen/api/element-request-fullscreen-not-allowed.html

Subtest	Results	Messages
	OK
`Element#requestFullscreen() when not allowed to request fullscreen`	FAIL	`assert_equals: event.target expected Element node <div id="log"></div> but got Document node with 2 children`

ghost · 2017-05-22T10:12:28Z

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 1cb8ea1
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

2 tests ran

/fullscreen/api/element-request-fullscreen-not-allowed.html

Subtest	Results	Messages
	OK
`Element#requestFullscreen() when not allowed to request fullscreen`	FAIL	`div.requestFullscreen is not a function. (In 'div.requestFullscreen()', 'div.requestFullscreen' is undefined)`

/fullscreen/interfaces.html

Subtest	Results	Messages
	OK
`Test driver`	FAIL	`Can't find variable: fetch`

ghost · 2017-05-22T10:12:28Z

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 2e09fc8
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran

/fullscreen/api/element-request-fullscreen-not-allowed.html

Subtest	Results	Messages
	OK
`Element#requestFullscreen() when not allowed to request fullscreen`	FAIL	`div.requestFullscreen is not a function. (In 'div.requestFullscreen()', 'div.requestFullscreen' is undefined)`

ghost · 2017-05-22T10:12:28Z

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 1cb8ea1
Using browser at version 60.0.3112.7 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran

/fullscreen/api/element-request-fullscreen-not-allowed.html

Subtest	Results	Messages
	OK
`Element#requestFullscreen() when not allowed to request fullscreen`	FAIL	`div.requestFullscreen is not a function`

/fullscreen/interfaces.html

Subtest	Results	Messages
	OK
`Test driver`	PASS
`Document interface: attribute fullscreenEnabled`	FAIL	`assert_true: The prototype object must have a property "fullscreenEnabled" expected true got false`
`Document interface: attribute fullscreen`	FAIL	`assert_true: The prototype object must have a property "fullscreen" expected true got false`
`Document interface: operation exitFullscreen()`	FAIL	`assert_own_property: interface prototype object missing non-static operation expected property "exitFullscreen" missing`
`Document interface: attribute onfullscreenchange`	FAIL	`assert_true: The prototype object must have a property "onfullscreenchange" expected true got false`
`Document interface: attribute onfullscreenerror`	FAIL	`assert_true: The prototype object must have a property "onfullscreenerror" expected true got false`
`Document interface: attribute fullscreenElement`	FAIL	`assert_true: The prototype object must have a property "fullscreenElement" expected true got false`
`Document must be primary interface of new Document`	PASS
`Stringification of new Document`	PASS
`Document interface: new Document must inherit property "fullscreenEnabled" with the proper type (29)`	FAIL	`assert_inherits: property "fullscreenEnabled" not found in prototype chain`
`Document interface: new Document must inherit property "fullscreen" with the proper type (30)`	FAIL	`assert_inherits: property "fullscreen" not found in prototype chain`
`Document interface: new Document must inherit property "exitFullscreen" with the proper type (31)`	FAIL	`assert_inherits: property "exitFullscreen" not found in prototype chain`
`Document interface: new Document must inherit property "onfullscreenchange" with the proper type (32)`	FAIL	`assert_inherits: property "onfullscreenchange" not found in prototype chain`
`Document interface: new Document must inherit property "onfullscreenerror" with the proper type (33)`	FAIL	`assert_inherits: property "onfullscreenerror" not found in prototype chain`
`Document interface: new Document must inherit property "fullscreenElement" with the proper type (35)`	FAIL	`assert_inherits: property "fullscreenElement" not found in prototype chain`
`ShadowRoot interface: attribute fullscreenElement`	FAIL	`assert_true: The prototype object must have a property "fullscreenElement" expected true got false`
`Element interface: operation requestFullscreen()`	FAIL	`assert_own_property: interface prototype object missing non-static operation expected property "requestFullscreen" missing`
`Element interface: attribute onfullscreenchange`	FAIL	`assert_true: The prototype object must have a property "onfullscreenchange" expected true got false`
`Element interface: attribute onfullscreenerror`	FAIL	`assert_true: The prototype object must have a property "onfullscreenerror" expected true got false`
`Element must be primary interface of document.createElementNS(null, "test")`	PASS
`Stringification of document.createElementNS(null, "test")`	PASS
`Element interface: document.createElementNS(null, "test") must inherit property "requestFullscreen" with the proper type (34)`	FAIL	`assert_inherits: property "requestFullscreen" not found in prototype chain`
`Element interface: document.createElementNS(null, "test") must inherit property "onfullscreenchange" with the proper type (35)`	FAIL	`assert_inherits: property "onfullscreenchange" not found in prototype chain`
`Element interface: document.createElementNS(null, "test") must inherit property "onfullscreenerror" with the proper type (36)`	FAIL	`assert_inherits: property "onfullscreenerror" not found in prototype chain`

ghost · 2017-05-22T10:12:28Z

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 59f2307
Using browser at version 60.0.3100.0 dev
Starting 10 test iterations
All results were stable

All results

1 test ran

/fullscreen/api/element-request-fullscreen-not-allowed.html

Subtest	Results	Messages
	OK
`Element#requestFullscreen() when not allowed to request fullscreen`	FAIL	`div.requestFullscreen is not a function`

ghost · 2017-05-22T10:12:29Z

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 1cb8ea1
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

2 tests ran

/fullscreen/api/element-request-fullscreen-not-allowed.html

Subtest	Results	Messages
	OK
`Element#requestFullscreen() when not allowed to request fullscreen`	FAIL	`Object doesn't support property or method 'requestFullscreen'`

/fullscreen/interfaces.html

Subtest	Results	Messages
	OK
`Test driver`	PASS
`Document interface: attribute fullscreenEnabled`	FAIL	`assert_true: The prototype object must have a property "fullscreenEnabled" expected true got false`
`Document interface: attribute fullscreen`	FAIL	`assert_true: The prototype object must have a property "fullscreen" expected true got false`
`Document interface: operation exitFullscreen()`	FAIL	`assert_own_property: interface prototype object missing non-static operation expected property "exitFullscreen" missing`
`Document interface: attribute onfullscreenchange`	FAIL	`assert_true: The prototype object must have a property "onfullscreenchange" expected true got false`
`Document interface: attribute onfullscreenerror`	FAIL	`assert_true: The prototype object must have a property "onfullscreenerror" expected true got false`
`Document interface: attribute fullscreenElement`	FAIL	`assert_true: The prototype object must have a property "fullscreenElement" expected true got false`
`Document must be primary interface of new Document`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`Stringification of new Document`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`Document interface: new Document must inherit property "fullscreenEnabled" with the proper type (29)`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`Document interface: new Document must inherit property "fullscreen" with the proper type (30)`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`Document interface: new Document must inherit property "exitFullscreen" with the proper type (31)`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`Document interface: new Document must inherit property "onfullscreenchange" with the proper type (32)`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`Document interface: new Document must inherit property "onfullscreenerror" with the proper type (33)`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`Document interface: new Document must inherit property "fullscreenElement" with the proper type (35)`	FAIL	`assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Function expected"`
`ShadowRoot interface: attribute fullscreenElement`	FAIL	`assert_own_property: self does not have own property "ShadowRoot" expected property "ShadowRoot" missing`
`Element interface: operation requestFullscreen()`	FAIL	`assert_own_property: interface prototype object missing non-static operation expected property "requestFullscreen" missing`
`Element interface: attribute onfullscreenchange`	FAIL	`assert_true: The prototype object must have a property "onfullscreenchange" expected true got false`
`Element interface: attribute onfullscreenerror`	FAIL	`assert_true: The prototype object must have a property "onfullscreenerror" expected true got false`
`Element must be primary interface of document.createElementNS(null, "test")`	PASS
`Stringification of document.createElementNS(null, "test")`	PASS
`Element interface: document.createElementNS(null, "test") must inherit property "requestFullscreen" with the proper type (34)`	FAIL	`assert_inherits: property "requestFullscreen" not found in prototype chain`
`Element interface: document.createElementNS(null, "test") must inherit property "onfullscreenchange" with the proper type (35)`	FAIL	`assert_inherits: property "onfullscreenchange" not found in prototype chain`
`Element interface: document.createElementNS(null, "test") must inherit property "onfullscreenerror" with the proper type (36)`	FAIL	`assert_inherits: property "onfullscreenerror" not found in prototype chain`

foolip · 2017-05-22T11:18:25Z

@bobholt, the result comments are duplicated on this PR, is this a known issue?

Fixes #89. Tests: web-platform-tests/wpt#6017

bobholt · 2017-05-22T11:50:05Z

@foolip: Not a known issue. As far as I can tell, it hasn't happened before (or in the PR since).

For this to have happened, prbuildbot would have had to been invoked twice within very short order (otherwise the comments would have existed, and the bot's check for existing comments would have caught them). I think we can see this born out in the matching timestamps in the duplicate comments. The only way I could explain that occurrence is if Travis somehow fired the webhook twice.

foolip · 2017-05-22T13:23:27Z

The only way I could explain that occurrence is if Travis somehow fired the webhook twice.

Presumably that can happen? If the server is very slow to respond, maybe it retries after a while, but the first request actually reached the system as well and just didn't get a reply?

bobholt · 2017-05-22T15:00:25Z

Presumably that can happen? If the server is very slow to respond, maybe it retries after a while, but the first request actually reached the system as well and just didn't get a reply?

I've seen Travis (rarely) respond twice to commands that are only invoked once in the build script, so it's not outside the realm of possibility to me that it could have fired 2 webhook POSTs.

If it waited any appreciable time between the two webhooks, we should only have seen one comment, as the previous comments would have already been in place (and found and edited by the script).

That said, I doubt Travis does any kind of webhook retry. It seems very "fire and forget." It's hard to tell, though, because they don't provide a UI into sent webhooks like GitHub does.

Fixes #89. Tests: web-platform-tests/wpt#6017

Follows whatwg/fullscreen#90.

foolip · 2017-05-30T08:26:03Z

@upsuper, would you mind reviewing this as well?

Fixes #89. Tests: web-platform-tests/wpt#6017

zcorpan

LGTM, but could have more coverage, in particular: if element is connected but its node document is not document, is not tested, is it?

foolip · 2017-05-31T12:20:30Z

-    assert_equals(iframeDoc.fullscreenElement, null);
+    assert_equals(document.fullscreenElement, null, "outer fullscreen element");
+    assert_equals(iframeDoc.fullscreenElement, null, "inner fullscreen element");
+    assert_equals(event.target, document, "event target");


@zcorpan, this and the same bit in element-request-fullscreen-and-remove-manual.html tests the event targeting.

upsuper · 2017-05-31T12:25:17Z

Is there test for checking what happens when the fullscreen element or any of its ancestor is removed from the document?

foolip · 2017-05-31T12:30:56Z

No, I'm now updating tests under model/ for that.

foolip · 2017-05-31T13:27:43Z

OK, I've tweaked the existing tests under model/ and added one new one. Please take another look.

upsuper · 2017-05-31T13:31:13Z

Will have a look tomorrow (hopefully).

zcorpan · 2017-06-01T11:46:43Z

Thanks. LGTM

wpt-pr-bot added the fullscreen label May 22, 2017

wpt-pr-bot requested review from aliams, jernoble and upsuper May 22, 2017 09:52

foolip added a commit to whatwg/fullscreen that referenced this pull request May 22, 2017

Fire events at elements by default, falling back to documents

5ac2091

Fixes #89. Tests: web-platform-tests/wpt#6017

wpt-pr-bot added the interfaces label May 22, 2017

foolip added a commit to whatwg/fullscreen that referenced this pull request May 24, 2017

Fire events at elements by default, falling back to documents

c186c6e

Fixes #89. Tests: web-platform-tests/wpt#6017

foolip mentioned this pull request May 24, 2017

Fire events at elements by default, falling back to documents whatwg/fullscreen#90

Merged

Update tests for fullscreen event targets (element or document)

24e3a1c

Follows whatwg/fullscreen#90.

foolip force-pushed the fullscreen-event-target branch from 2e32b23 to 24e3a1c Compare May 24, 2017 08:25

foolip requested a review from zcorpan May 31, 2017 08:36

foolip added a commit to whatwg/fullscreen that referenced this pull request May 31, 2017

Fire events at elements by default, falling back to documents

1b2fac9

Fixes #89. Tests: web-platform-tests/wpt#6017

zcorpan approved these changes May 31, 2017

View reviewed changes

foolip commented May 31, 2017

View reviewed changes

foolip added 2 commits May 31, 2017 14:40

fixup! Update tests for fullscreen event targets (element or document)

31f5c8b

fixup! Update tests for fullscreen event targets (element or document)

4b667df

upsuper approved these changes Jun 1, 2017

View reviewed changes

foolip merged commit 61057da into master Jun 1, 2017

foolip deleted the fullscreen-event-target branch June 1, 2017 08:15

Conversation

foolip commented May 22, 2017 • edited by wpt-pr-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented May 22, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Firefox (nightly)

All results

Uh oh!

ghost commented May 22, 2017

Firefox (nightly)

All results

Uh oh!

ghost commented May 22, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sauce (safari)

All results

Uh oh!

ghost commented May 22, 2017

Sauce (safari)

All results

Uh oh!

ghost commented May 22, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chrome (unstable)

All results

Uh oh!

ghost commented May 22, 2017

Chrome (unstable)

All results

Uh oh!

ghost commented May 22, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sauce (MicrosoftEdge)

All results

Uh oh!

foolip commented May 22, 2017

Uh oh!

bobholt commented May 22, 2017

Uh oh!

foolip commented May 22, 2017

Uh oh!

bobholt commented May 22, 2017

Uh oh!

foolip commented May 30, 2017

Uh oh!

zcorpan left a comment

Choose a reason for hiding this comment

Uh oh!

foolip May 31, 2017

Choose a reason for hiding this comment

Uh oh!

upsuper commented May 31, 2017

Uh oh!

foolip commented May 31, 2017

Uh oh!

foolip commented May 31, 2017

Uh oh!

upsuper commented May 31, 2017

Uh oh!

zcorpan commented Jun 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

foolip commented May 22, 2017 •

edited by wpt-pr-bot

Loading

ghost commented May 22, 2017 •

edited by ghost

Loading

ghost commented May 22, 2017 •

edited by ghost

Loading

ghost commented May 22, 2017 •

edited by ghost

Loading

ghost commented May 22, 2017 •

edited by ghost

Loading