Skip to content

Submission/opera/server sent events#60

Merged
odinho merged 25 commits intomasterfrom
submission/Opera/ServerSentEvents
Apr 30, 2013
Merged

Submission/opera/server sent events#60
odinho merged 25 commits intomasterfrom
submission/Opera/ServerSentEvents

Conversation

@odinho
Copy link
Contributor

@odinho odinho commented Apr 4, 2013

The server sent events, formerly at https://github.com/w3c/event-source

There's some non-opera code here too.

Some of it would need a readthrough to see if it matches spec.

James Graham and others added 25 commits October 27, 2012 11:13
Refactoring: async_test now accepts a function.
for content-type:
The charset parameter may be provided. The parameter's value must be "utf-8". This parameter serves no purpose; it is only allowed for compatibility with legacy servers
>>Once the end of the file is reached, any pending data must be discarded. (If the file ends in the middle of an event, before the final empty line, the incomplete event is not dispatched.)
message.php adds one "\n" at the end, but we need one extra,
aldo "data\r" is removed, as it adds one new line to the event.data
Once the end of the file is reached, any pending data must be discarded. (If the file ends in the middle of an event, before the final empty line, the incomplete event is not dispatched.)
avoid of warnings
Update format-comments.htm with newline on last event (4)
Update format-field-parsing.htm
Avoid warnings in resources/message.php
Test for null character in server response (buggy in Opera)
new test for "Once the end of the file is reached, any pending data must be discarded. (If the file ends in the middle of an event, before the final empty line, the incomplete event is not dispatched.)"
Update format-utf-8.htm, everything but UTF-8 should be disallowed.
Update format-field-data.htm
@AFBarstow
Copy link
Contributor

Is this PR ready to be merged? My understanding is that all of these tests have been removed by at least Tina (Intel).

@AFBarstow
Copy link
Contributor

Darn, comment above: s/removed/reviewed/ ;-)

@odinho
Copy link
Contributor Author

odinho commented Apr 30, 2013

Yes. Tina is basically submitting them then ;-) Merging in.

odinho added a commit that referenced this pull request Apr 30, 2013
@odinho odinho merged commit 8744c85 into master Apr 30, 2013
@odinho odinho deleted the submission/Opera/ServerSentEvents branch April 30, 2013 16:17
@odinho
Copy link
Contributor Author

odinho commented Apr 30, 2013

I also moved the tests and removed the mosquito ones.

jugglinmike pushed a commit to bocoup/wpt that referenced this pull request Apr 11, 2017
jgraham added a commit that referenced this pull request Apr 13, 2017
AutomatedTester referenced this pull request in AutomatedTester/web-platform-tests Dec 1, 2017
Saves memory without downsides.

Ref #60
AutomatedTester referenced this pull request in AutomatedTester/web-platform-tests Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants