Implement new/revised popover=hint behavior by chromium-wpt-export-bot · Pull Request #59237 · web-platform-tests/wpt

chromium-wpt-export-bot · 2026-04-15T13:48:10Z

See this discussion for more context:

This CL implements a simplified behavioral model for popover=hint and
popover=auto, cleanly separating the autoRootedPopoverStack from the
hintRootedPopoverStack and introducing a hintStackParent to track
where the hint stack branches off the auto stack.

The new behavior resolves the following inconsistencies (gated behind
the PopoverHintNewBehavior experimental runtime flag):

Opening a hint popover will not hide unrelated auto popovers.
Opening a hint popover closes only other non-ancestor hint
popovers.
Clicking outside consistently closes both auto and hint popovers.
Hiding an auto popover closes only its child popovers.
Opening an auto popover inside a hint popover is disallowed and
will fail.

A new WPT test (popover-hint-hierarchy.html) is added to explicitly
assert these 5 rules, and existing popover WPTs are updated to reflect
the new behavior. A virtual test suite (popover-hint-old-behavior)
is also added to continue testing the legacy behavior. I'm not sure
how to best handle the changed tests (and I guess the new test too)
in the context of a spec PR that is forthcoming. I'd like to be able
to publish (as a WPT PR at least) the changes, to help with the PR
effort. Suggestions appreciated.

A note about the diff: I made all of the feature flag checks look like
if (!feature enabled) { in the hopes that the old code would show
as unchanged in the diff, but gerrit's diff algorithm isn't great.
It's at least a little better like this than if I put the new code
first, so I left it.

Bug: 4990199
Change-Id: I41d8d96be71ba60ec5e7aa640c935258d1e33431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7727959
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1615186}

azure-pipelines · 2026-04-15T13:48:26Z

Azure Pipelines: Successfully started running 1 pipeline(s).

See this discussion for more context: whatwg/html#12304 whatwg/html#12345 This CL implements a simplified behavioral model for popover=hint and popover=auto, cleanly separating the autoRootedPopoverStack from the hintRootedPopoverStack and introducing a `hintStackParent` to track where the hint stack branches off the auto stack. The new behavior resolves the following inconsistencies (gated behind the `PopoverHintNewBehavior` experimental runtime flag): 1. Opening a hint popover will not hide unrelated auto popovers. 2. Opening a hint popover closes only other non-ancestor hint popovers. 3. Clicking outside consistently closes both auto and hint popovers. 4. Hiding an auto popover closes only its child popovers. 5. Opening an auto popover inside a hint popover is disallowed and will fail. A new WPT test (`popover-hint-hierarchy.html`) is added to explicitly assert these 5 rules, and existing popover WPTs are updated to reflect the new behavior. A virtual test suite (`popover-hint-old-behavior`) is also added to continue testing the legacy behavior. I'm not sure how to best handle the changed tests (and I guess the new test too) in the context of a spec PR that is forthcoming. I'd like to be able to publish (as a WPT PR at least) the changes, to help with the PR effort. Suggestions appreciated. A note about the diff: I made all of the feature flag checks look like `if (!feature enabled) {` in the hopes that the old code would show as unchanged in the diff, but gerrit's diff algorithm isn't great. It's at least a little better like this than if I put the new code first, so I left it. Bug: 4990199 Change-Id: I41d8d96be71ba60ec5e7aa640c935258d1e33431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7727959 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1615186}

wpt-pr-bot

The review process for this patch is being conducted in the Chromium project.

azure-pipelines · 2026-04-15T15:53:26Z

Azure Pipelines: Successfully started running 1 pipeline(s).

azure-pipelines · 2026-04-15T15:53:34Z

Azure Pipelines: Successfully started running 1 pipeline(s).

jgraham · 2026-04-20T13:09:29Z

@jakearchibald are you able to review this change?

jakearchibald · 2026-04-20T13:13:34Z

Yeah, I'm planning to go through it today

jakearchibald

Looks good so far! Just needs to cater for the newer stuff:

Auto can be within hint (but it downgrades).
showPopover within the hide/show of a popover should throw/no-op.

I think you mentioned there was a test here somewhere that tested incorrect behaviour… well… I failed to find it. Hah!

jakearchibald · 2026-04-20T17:31:57Z

+// this is "weirdness 5" from https://github.com/whatwg/html/issues/12304
+promise_test(async (t) => {
+  t.add_cleanup(hideAll);
+
+  hint1.showPopover();
+  assertOpen('initial',hint1);
+
+  // Imperative
+  assert_throws_dom('InvalidStateError', () => {
+    auto1.showPopover({source: hint1});
+  }, 'Opening auto popover inside hint popover is not allowed');
+  assertOpen('after show',hint1);
+
+  // Declarative
+  const invoker = document.createElement('button');
+  invoker.popoverTargetElement = auto1;
+  t.add_cleanup(() => invoker.remove());
+  hint1.appendChild(invoker);
+  await clickOn(invoker);
+  assertOpen('after click',hint1);
+}, 'Opening an auto popover inside a hint popover is disallowed and will fail.');


You may have already done this, but in case it helps…

Suggested change

// this is "weirdness 5" from https://github.com/whatwg/html/issues/12304

promise_test(async (t) => {

t.add_cleanup(hideAll);

hint1.showPopover();

assertOpen('initial',hint1);

// Imperative

assert_throws_dom('InvalidStateError', () => {

auto1.showPopover({source: hint1});

}, 'Opening auto popover inside hint popover is not allowed');

assertOpen('after show',hint1);

// Declarative

const invoker = document.createElement('button');

invoker.popoverTargetElement = auto1;

t.add_cleanup(() => invoker.remove());

hint1.appendChild(invoker);

await clickOn(invoker);

assertOpen('after click',hint1);

}, 'Opening an auto popover inside a hint popover is disallowed and will fail.');

// this is "weirdness 5" from https://github.com/whatwg/html/issues/12304

promise_test(async (t) => {

t.add_cleanup(hideAll);

auto1.showPopover();

hint1.showPopover({source: auto1});

assertOpen('initial', auto1, hint1);

auto2.showPopover({source: hint1});

assertOpen('auto opened inside hint', auto1, hint1, auto2);

hint2.showPopover({source: hint1});

assertOpen('auto exhibits hint-like behavior', auto1, hint1, hint2);

}, 'Auto popovers opened inside hint popovers are downgraded to hint behaviors');

Yeah, this is done in this change.

jakearchibald · 2026-04-20T18:01:12Z

 <div>
  <div popover="hint">Hint
    <div popover>Nested auto (note - never visible, since inside display:none subtree)</div>
  </div>
  <script>
  test(() => {
    const hint = getPopovers()[0];
    const auto = getPopovers()[1];
    hint.showPopover();
    assertState([true,false]);
-    auto.showPopover();
-    assertState([false,true]);
-    auto.hidePopover();
+    assert_throws_dom('InvalidStateError', () => {
+      auto.showPopover();
+    });
+    assertState([true,false]);
+    hint.hidePopover();
    assertState([false,false]);
  },'If a popover=auto is shown, it should hide any open popover=hint, including if the popover=hint is an ancestral popover of the popover=auto. (You can\'t nest a popover=auto inside a popover=hint)');
  </script>
 </div>


Suggested change

<div>

<div popover="hint">Hint

<div popover>Nested auto</div>

</div>

<script>

test(() => {

const hint = getPopovers()[0];

const auto = getPopovers()[1];

hint.showPopover();

assertState([true,false]);

auto.showPopover();

assertState([true,true]);

hint.hidePopover();

assertState([false,false]);

},'If a popover=auto is shown within a popover=hint, it should be shown');

</script>

</div>

https://chromium-review.git.corp.google.com/c/chromium/src/+/7787494/4/third_party/blink/web_tests/external/wpt/html/semantics/popovers/popover-types-with-hints.html

jakearchibald · 2026-04-20T18:13:43Z

Need to cater for 'auto' being allowed inside 'hint'. Watch out for stuff outside tests too, like "Improperly nested".

This is handled in #3 of the followup CLs:

whatwg/html#12345 (comment)

jonathan-j-lee · 2026-04-23T18:52:35Z

@mfreed7 To address the review, you can push some extra commits on this branch. The changes will propagate back to chromium/src on the next import.

Co-authored-by: Jake Archibald <jaffathecake@gmail.com>

mfreed7 · 2026-04-23T21:00:19Z

@mfreed7 To address the review, you can push some extra commits on this branch. The changes will propagate back to chromium/src on the next import.

I'm guessing they will then create additional havoc with the dependent patches that change the same tests, but I guess we'll see!

mfreed7 · 2026-05-05T15:15:08Z

Can we land this?

jonathan-j-lee · 2026-05-07T00:25:18Z

@jakearchibald @jgraham ^

- Showing a hint popover doesn't hide auto popovers. - Showing a hint popover hides non-parent hint popovers. - Clicking outside popovers consistently hides them. - Hiding an auto popover does not hide unrelated hint popovers. - Showing an auto popover as a child of a hint popover downgrades the auto popover to a hint. - Showing a popover during the show or hide of another popover is no longer allowed. Tests: web-platform-tests/wpt#59237. Fixes #12304, fixes #12346 fixes #12355, and fixes #12356.

jgraham

From an Interop point of view, this is approved by the vendors who are affected by the change, so it's fine to land.

mfreed7 · 2026-05-14T20:25:29Z

From an Interop point of view, this is approved by the vendors who are affected by the change, so it's fine to land.

Thanks!

@jonathan-j-lee, do you happen to know how long it takes Chromium's infra to upload the next in the series? I'd love to get all of those landed, so that we can make sure the final collection looks good to everyone. It's pretty difficult to do that as-is.

jonathan-j-lee · 2026-05-15T17:58:17Z

I've paused @chromium-wpt-export-bot because of crashes related to jj using Link instead of Change-Id footers (https://crbug.com/513548026#comment2). @patrykchodur
has contributed a fix here: https://crrev.com/c/7852456

mfreed7 · 2026-05-18T15:09:50Z

I've paused @chromium-wpt-export-bot because of crashes related to jj using Link instead of Change-Id footers (https://crbug.com/513548026#comment2). @patrykchodur has contributed a fix here: https://crrev.com/c/7852456

Thanks @jonathan-j-lee. It also seems like the importer is borked because of the changes made during the review of this PR: https://crbug.com/513412137.

chromium-wpt-export-bot added chromium-export do not merge yet labels Apr 15, 2026

mfreed7 mentioned this pull request Apr 15, 2026

Simplify popover=hint behaviours & related spec fixes whatwg/html#12345

Merged

11 tasks

chromium-wpt-export-bot marked this pull request as ready for review April 15, 2026 15:53

chromium-wpt-export-bot requested a review from a team as a code owner April 15, 2026 15:53

chromium-wpt-export-bot force-pushed the chromium-export-cl-7727959 branch from c20a11f to 3995ae4 Compare April 15, 2026 15:53

chromium-wpt-export-bot removed the do not merge yet label Apr 15, 2026

wpt-pr-bot added the html label Apr 15, 2026

wpt-pr-bot approved these changes Apr 15, 2026

View reviewed changes

jakearchibald requested changes Apr 20, 2026

View reviewed changes

jakearchibald reviewed Apr 20, 2026

View reviewed changes

Comment thread html/semantics/popovers/resources/popover-top-layer-nesting.js

mfreed7 and others added 4 commits April 23, 2026 13:53

Apply suggestion from @jakearchibald

d74a501

Co-authored-by: Jake Archibald <jaffathecake@gmail.com>

Undo changes to this file

2a2d174

Spaces

c4dcfb3

Apply suggestion from @jakearchibald

7a3d031

Co-authored-by: Jake Archibald <jaffathecake@gmail.com>

jonathan-j-lee requested a review from jakearchibald April 23, 2026 22:13

nairnandu mentioned this pull request May 11, 2026

Agenda for May 7, 2026 web-platform-tests/interop#1283

Closed

jakearchibald approved these changes May 14, 2026

View reviewed changes

jgraham approved these changes May 14, 2026

View reviewed changes

chromium-wpt-export-bot merged commit 7c5c871 into master May 14, 2026
25 checks passed

chromium-wpt-export-bot deleted the chromium-export-cl-7727959 branch May 14, 2026 10:12

jonathan-j-lee mentioned this pull request May 15, 2026

Fix a bug in new popover=hint stacking behavior, and update tests #59915

Closed

Conversation

chromium-wpt-export-bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Apr 15, 2026

Uh oh!

wpt-pr-bot left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Apr 15, 2026

Uh oh!

azure-pipelines Bot commented Apr 15, 2026

Uh oh!

jgraham commented Apr 20, 2026

Uh oh!

jakearchibald commented Apr 20, 2026

Uh oh!

jakearchibald left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakearchibald Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

mfreed7 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

jakearchibald Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

mfreed7 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakearchibald Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

mfreed7 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonathan-j-lee commented Apr 23, 2026

Uh oh!

mfreed7 commented Apr 23, 2026

Uh oh!

mfreed7 commented May 5, 2026

Uh oh!

jonathan-j-lee commented May 7, 2026

Uh oh!

jgraham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mfreed7 commented May 14, 2026

Uh oh!

jonathan-j-lee commented May 15, 2026

Uh oh!

mfreed7 commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chromium-wpt-export-bot commented Apr 15, 2026 •

edited

Loading

jakearchibald left a comment •

edited

Loading