Assert that an unnecessary exitFullscreen()'s promise is resolved#5872
Merged
Conversation
Collaborator
foolip
added a commit
to whatwg/fullscreen
that referenced
this pull request
May 10, 2017
Given that there is an "unfullscreen a document" operation, this algorithm can easily be assumed to be the set of documents for which that should be called, i.e., that all of the documents returned will exit fully. At the beginning of the animation frame task there's no guarantee that doc still has a fullscreen element, but later in "unfullscreen exitDoc's fullscreen element" it is assumed to have one. Fix this with an early return. Test: web-platform-tests/wpt#5872
Member
Author
|
Nobody implements promises yet, so this test deliberately doesn't fail if so. I've verified that the test still passes in Firefox with the changes, but beyond that the test may need tweaking once promises are supported. This is the only way that the change in whatwg/fullscreen#81 would be observable. |
Firefox (nightly)Testing web-platform-tests at revision 0da3aff |
Chrome (unstable)Testing web-platform-tests at revision 0da3aff |
foolip
added a commit
to whatwg/fullscreen
that referenced
this pull request
May 11, 2017
Given that there is an "unfullscreen a document" operation, this algorithm can easily be assumed to be the set of documents for which that should be called, i.e., that all of the documents returned will exit fully. At the beginning of the animation frame task there's no guarantee that doc still has a fullscreen element, but later in "unfullscreen exitDoc's fullscreen element" it is assumed to have one. Fix this with an early return. Test: web-platform-tests/wpt#5872
Member
|
I think this is fine. |
Member
Author
|
Thanks @upsuper! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test for whatwg/fullscreen#81