Add tests for the messageerror IDL and content attributes#5567
Merged
Add tests for the messageerror IDL and content attributes#5567
Conversation
Follows whatwg/html#2530. As explained there, the circumstances in which this would actually be fired by the UA are not tested in this PR, waiting instead for #5003. As a side effect this syncs various IDL snippets with the HTML Standard.
Collaborator
|
Notifying @annevk, @aogilvie, @ayg, @jdm, @mkruisselbrink, and @zqzhang. (Learn how reviewing works.) |
LintPassed |
|
*This report has been truncated because the total content is 2989260 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Firefox (nightly channel)Testing web-platform-tests at revision de241dd All results3 tests ran/html/dom/interfaces.html
|
|
*This report has been truncated because the total content is 3016726 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Chrome (unstable channel)Testing web-platform-tests at revision de241dd All results3 tests ran/html/dom/interfaces.html
|
annevk
approved these changes
Apr 15, 2017
Member
annevk
left a comment
There was a problem hiding this comment.
This also adds onrejectionhandled and onunhandledrejection and aligns IDL around transferable changes, but that all looks reasonable.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Apr 24, 2017
The messageerror event is used when deserialization fails. E.g., when an ArrayBuffer object cannot be allocated. This also removes StructuredCloneWithTransfer as deserializing errors now need to be handled on their own. Tests: web-platform-tests/wpt#5567. Service workers follow-up: w3c/ServiceWorker#1116. Fixes part of #2260 and fixes #935.
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Apr 24, 2017
The messageerror event is used when deserialization fails. E.g., when an ArrayBuffer object cannot be allocated. This also removes StructuredCloneWithTransfer as deserializing errors now need to be handled on their own. Tests: web-platform-tests/wpt#5567. Service workers follow-up: w3c/ServiceWorker#1116. Fixes part of #2260 and fixes #935.
binji
reviewed
Apr 29, 2017
|
|
||
| document.body.setAttribute("onmessageerror", "window.messageErrorHappened = true;") | ||
|
|
||
| document.body.dispatchEvent(new Event("messageerror")); |
Contributor
There was a problem hiding this comment.
I'm curious about this test -- if I try the same thing with onmessage and message instead, it doesn't fire on Chrome or Firefox. Is there something special about the messageerror event here? Or am I missing something?
(BTW, it works fine if the event is dispatched on window instead of document.body)
Member
Author
There was a problem hiding this comment.
If it doesn't work with message, that's likely a sign this test is bad. I'll look into it first thing on Monday. The fix might indeed just be dispatching on window.
Member
Author
There was a problem hiding this comment.
This test appears to be just invalid, yeah. I'll submit a PR removing it.
domenic
added a commit
that referenced
this pull request
May 1, 2017
This is a follow-up to #5567. As pointed out in https://github.com/w3c/web-platform-tests/pull/5567/files#r114040410, this test is invalid. messageerror (and message) have their corresponding event handler content attributes on document.body, but with the actual event handler belonging to Window.
domenic
added a commit
that referenced
this pull request
May 1, 2017
This is a follow-up to #5567. As pointed out in https://github.com/w3c/web-platform-tests/pull/5567/files#r114040410, this test is invalid. messageerror (and message) have their corresponding event handler content attributes on document.body, but with the actual event handler belonging to Window.
inikulin
pushed a commit
to HTMLParseErrorWG/html
that referenced
this pull request
May 9, 2017
The messageerror event is used when deserialization fails. E.g., when an ArrayBuffer object cannot be allocated. This also removes StructuredCloneWithTransfer as deserializing errors now need to be handled on their own. Tests: web-platform-tests/wpt#5567. Service workers follow-up: w3c/ServiceWorker#1116. Fixes part of whatwg#2260 and fixes whatwg#935.
inikulin
pushed a commit
to HTMLParseErrorWG/html
that referenced
this pull request
May 9, 2017
The messageerror event is used when deserialization fails. E.g., when an ArrayBuffer object cannot be allocated. This also removes StructuredCloneWithTransfer as deserializing errors now need to be handled on their own. Tests: web-platform-tests/wpt#5567. Service workers follow-up: w3c/ServiceWorker#1116. Fixes part of whatwg#2260 and fixes whatwg#935.
scheib
pushed a commit
to scheib/chromium
that referenced
this pull request
May 13, 2017
This event is not currently wired up anywhere, but will be used in a subsequent CL. The idea is that when posting a message that cannot be decoded by the receiver, the receiver will dispatch a messageerror event instead of a message event. Spec changes: whatwg/html#2530 web platform tests: web-platform-tests/wpt#5567 Intent-to-implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z_XzejHJTrs BUG=chromium:714842 Review-Url: https://codereview.chromium.org/2860483002 Cr-Commit-Position: refs/heads/master@{#471491}
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
The messageerror event is used when deserialization fails. E.g., when an ArrayBuffer object cannot be allocated. This also removes StructuredCloneWithTransfer as deserializing errors now need to be handled on their own. Tests: web-platform-tests/wpt#5567. Service workers follow-up: w3c/ServiceWorker#1116. Fixes part of whatwg#2260 and fixes whatwg#935.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows whatwg/html#2530. As explained there, the circumstances in which this would actually be fired by the UA are not tested in this PR, waiting instead for #5003.
As a side effect this syncs various IDL snippets with the HTML Standard.
FYI @binji @mtrofin on the Blink side, @lars-t-hansen on the Gecko side.
This change is