[wasm] ESM Integration import maps test#53722
[wasm] ESM Integration import maps test#53722guybedford wants to merge 3 commits intoweb-platform-tests:masterfrom
Conversation
|
I don't know how other wasm WPT tests are written, but it'd be helpful to also have the .wat file to:
|
|
Mostly we've dynamically generated wasm binaries from js within the test, but I agree we shouldn't put binary wasm in the repo without a source and perhaps added to tools/ci/update_built.py |
|
@Ms2ger yes we can't dynamically construct Wasm when testing static imports. Note that we already have multiple compiled Wasm cases in the webapi folder:
In general the main loss over having something like The ideal approach might be to have a WPT harness approach that allows I wonder if something like that might be possible? I think it should be a separate PR though. |
That would be really nice, if possible. In general the text format is so much easier to use. GH has support for displaying binary files specially depending on their file format. I opened a community discussion to see if they would consider adding wasm support. |
cfdb064 to
fa4225d
Compare
|
The feedback here has now been addressed. |
This adds a new WebAssembly webapi test for the integration of import maps and WebAssembly module imports.
This tests specifier mappings for Wasm along with string builtins support. It also tests the ability for unknown string builtins to fallback to mapped implementations as public non-compile-time imports.
//cc @eqrion this should provide additional coverage for WebAssembly/js-string-builtins#46.