Closed
Conversation
Contributor
|
Now that work on lv2 has stopped, do we still need tests for it? |
Member
|
@darobin this PR has been open for more than one year |
Member
|
@darobin radio check |
Contributor
|
Most of this landed over the years; the remainder is now #1562. |
jgraham
added a commit
that referenced
this pull request
Apr 13, 2017
Explicitly pass the url_base to filesystem_path so the correct paths can be constructed.
jgraham
pushed a commit
that referenced
this pull request
Apr 21, 2017
Add a finish handler to the Servo executor.
jgraham
added a commit
that referenced
this pull request
Apr 24, 2017
88c5c5b6bb chore(package): bump version 8b3bc38a24 chore(package): bump version c64fe13a42 chore(package): update deps a0bccdf485 fix "Trailing comma in extended attribute" error (#63) 62633a1025 Remove support for MapClass (no longer valid in WebIDL) (#62) 3a7d1bbe3e Merge pull request #61 from w3c/annotated_types 49ea372ba3 Fix spaces in JSON output for updated test 7488ee661f docs(README): fix markdown. 5530e9fecc Adapt test to support for annotated types a387b679ca Add support for annotated types ffe9400aba Merge pull request #58 from SaschaNaz/namespace 9a154bb963 implement namespace 830d19191f chore(package): bump version e5771f11e8 Revert "style: use U.S. English" 8c712c9cb8 chore(package): bump version 8ee9a85ad8 style: use U.S. English bc7b7c6897 style(lib): beautify code 96699646e1 chore(package): bump version 86ea904cbf chore(package): update dependencies 44d7b22851 Merge pull request #57 from TimothyGu/develop 0b5300ec76 Make writer less strict about generic idlType's type 064622bf59 Add support for records fcb88fb1ac Merge pull request #50 from w3c/refactor a23527043e refactor(webidl.js): move WebIDLParseError c64e97c3b8 Merge pull request #49 from w3c/amd_compat d1e704bd40 feat(lib): add AMD export support (closes #48) 5458831df8 style(writer.js): fix whitespace 481c29427a style(webidl2.js): fix whitespace ed24e286ee chore(package): update deps 2668a8be5f docs(README): fixup markdown highlighting 9df3430244 Merge pull request #47 from mkwtys/fix-default ec61c0a096 Merge branch 'halton-replace_expect' into develop fb59b13c2c Really be deterministic 128d7335bb Remove reliance on undeterministic object key order 7bf2df2276 Confirm support for union in typedef 1b5b83438e Remove test of now invalid nested typdef 2d8cd93bd4 Update location of expect.js library 1ed22de9b5 Correct jsondiffpatch location. a2e2f8e902 Bump microtime to 2.1.1 23b63723e9 Expand writer support 9cc1281a1c Accept wider (but still incomplete) set of allowed syntax for extended attributes. cb04f7777c Identifier allow `-` d9b4989425 Merge pull request #39 from markandrus/develop 1ab320df8d Merge pull request #37 from artillery/develop 524000bfd6 Merge pull request #31 from othree/in-draft 99127088c2 Fix `"default": undefined` 191685b05f Really be deterministic 300b1e0fae Remove reliance on undeterministic object key order 61c8e65035 Confirm support for union in typedef f0cd831c6c Remove test of now invalid nested typdef 77b5e3df87 Update location of expect.js library f84b8e684c Merge pull request #44 from halton/fix_jsondiffpatch b52117cf05 Merge pull request #43 from halton/bump_microtime 65382bf16b Replace expect.js with expct be6c2e21e9 Correct jsondiffpatch location. 0b0fa3e92d Bump microtime to 2.1.1 e470735423 Expand writer support 9e2ccfc940 Accept wider (but still incomplete) set of allowed syntax for extended attributes. 989591f675 Allow trailing comma in enum 9385d07a54 Identifier allow `-` git-subtree-dir: resources/webidl2 git-subtree-split: 88c5c5b6bb675d0d95ae3ec4db3258768d0c8fc0
jgraham
added a commit
that referenced
this pull request
Apr 26, 2017
) 88c5c5b6bb chore(package): bump version 8b3bc38a24 chore(package): bump version c64fe13a42 chore(package): update deps a0bccdf485 fix "Trailing comma in extended attribute" error (#63) 62633a1025 Remove support for MapClass (no longer valid in WebIDL) (#62) 3a7d1bbe3e Merge pull request #61 from w3c/annotated_types 49ea372ba3 Fix spaces in JSON output for updated test 7488ee661f docs(README): fix markdown. 5530e9fecc Adapt test to support for annotated types a387b679ca Add support for annotated types ffe9400aba Merge pull request #58 from SaschaNaz/namespace 9a154bb963 implement namespace 830d19191f chore(package): bump version e5771f11e8 Revert "style: use U.S. English" 8c712c9cb8 chore(package): bump version 8ee9a85ad8 style: use U.S. English bc7b7c6897 style(lib): beautify code 96699646e1 chore(package): bump version 86ea904cbf chore(package): update dependencies 44d7b22851 Merge pull request #57 from TimothyGu/develop 0b5300ec76 Make writer less strict about generic idlType's type 064622bf59 Add support for records fcb88fb1ac Merge pull request #50 from w3c/refactor a23527043e refactor(webidl.js): move WebIDLParseError c64e97c3b8 Merge pull request #49 from w3c/amd_compat d1e704bd40 feat(lib): add AMD export support (closes #48) 5458831df8 style(writer.js): fix whitespace 481c29427a style(webidl2.js): fix whitespace ed24e286ee chore(package): update deps 2668a8be5f docs(README): fixup markdown highlighting 9df3430244 Merge pull request #47 from mkwtys/fix-default ec61c0a096 Merge branch 'halton-replace_expect' into develop fb59b13c2c Really be deterministic 128d7335bb Remove reliance on undeterministic object key order 7bf2df2276 Confirm support for union in typedef 1b5b83438e Remove test of now invalid nested typdef 2d8cd93bd4 Update location of expect.js library 1ed22de9b5 Correct jsondiffpatch location. a2e2f8e902 Bump microtime to 2.1.1 23b63723e9 Expand writer support 9cc1281a1c Accept wider (but still incomplete) set of allowed syntax for extended attributes. cb04f7777c Identifier allow `-` d9b4989425 Merge pull request #39 from markandrus/develop 1ab320df8d Merge pull request #37 from artillery/develop 524000bfd6 Merge pull request #31 from othree/in-draft 99127088c2 Fix `"default": undefined` 191685b05f Really be deterministic 300b1e0fae Remove reliance on undeterministic object key order 61c8e65035 Confirm support for union in typedef f0cd831c6c Remove test of now invalid nested typdef 77b5e3df87 Update location of expect.js library f84b8e684c Merge pull request #44 from halton/fix_jsondiffpatch b52117cf05 Merge pull request #43 from halton/bump_microtime 65382bf16b Replace expect.js with expct be6c2e21e9 Correct jsondiffpatch location. 0b0fa3e92d Bump microtime to 2.1.1 e470735423 Expand writer support 9e2ccfc940 Accept wider (but still incomplete) set of allowed syntax for extended attributes. 989591f675 Allow trailing comma in enum 9385d07a54 Identifier allow `-` git-subtree-dir: resources/webidl2 git-subtree-split: 88c5c5b6bb675d0d95ae3ec4db3258768d0c8fc0
AutomatedTester
referenced
this pull request
in AutomatedTester/web-platform-tests
Dec 1, 2017
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 17, 2019
…se functionality This change sets the groundwork for the toast closebutton, by adding an attribute to set the closebutton content, creating a closeButton property to reflect that attribute, and adding an event listener to close the toast when the closebutton is pressed. This change implements the close button API described in (https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md), and is the subject of debate on issue #48 on the explainer here jackbsteinberg/std-toast#48. Future CLs will add the closeButton option for showToast (https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options) Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453 Bug:972945 Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 18, 2019
…se functionality This change sets the groundwork for the toast closebutton, by adding an attribute to set the closebutton content, creating a closeButton property to reflect that attribute, and adding an event listener to close the toast when the closebutton is pressed. This change implements the close button API described in (https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md), and is the subject of debate on issue #48 on the explainer here jackbsteinberg/std-toast#48. Future CLs will add the closeButton option for showToast (https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options) Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453 Bug: 972945 Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269 Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678530}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 18, 2019
…se functionality This change sets the groundwork for the toast closebutton, by adding an attribute to set the closebutton content, creating a closeButton property to reflect that attribute, and adding an event listener to close the toast when the closebutton is pressed. This change implements the close button API described in (https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md), and is the subject of debate on issue #48 on the explainer here jackbsteinberg/std-toast#48. Future CLs will add the closeButton option for showToast (https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options) Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453 Bug: 972945 Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269 Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678530}
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
…se functionality This change sets the groundwork for the toast closebutton, by adding an attribute to set the closebutton content, creating a closeButton property to reflect that attribute, and adding an event listener to close the toast when the closebutton is pressed. This change implements the close button API described in (https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md), and is the subject of debate on issue web-platform-tests#48 on the explainer here jackbsteinberg/std-toast#48. Future CLs will add the closeButton option for showToast (https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options) Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453 Bug: 972945 Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269 Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678530}
fred-wang
added a commit
that referenced
this pull request
Sep 11, 2019
…m in-flow children. This basically duplicates existing tests but adds some absolute-positioned and display: none <mn> that should't affect layout. Note that the case of float is still undecided (see #48).
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 4, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 4, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 5, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 6, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#747644}
Hexcles
pushed a commit
that referenced
this pull request
Mar 6, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#747644}
moz-wptsync-bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
…hich has only a collapsible white-space In bug 1925635, I moved the post processing after deleting ranges in `EditorBase::DeleteRangesWithTransaction` into the `HTMLEditor`'s override. At this time, I makes it uses `HTMLEditUtils::IsEmptyNode` to check whether the `Text` and its containers become empty. Therefore, if `Ctrl`+`Backspace` deletes the only word in the `Text` which starts with a collapsible white-space causes deleting the `Text` after deleting all visible characters in the `Text`. Therefore, this makes check it with `Text::TextDataLength` too before searching the most distant ancestor inline element which becomes empty. However, it may cause leading invisible white-spaces of the only word visible because `nsFrameSelection` computes the word range strictly in the `Text`. Therefore, this patch also makes `HTMLEditor::DeleteRangesWithTransaction` and `AutoDeleteRangesHandler::ComputeRangesToDeleteRangesWithTransaction` extend each range to delete to include surrounding invisible white-spaces too. Therefore, this patch adds the new method to `AutoClonedRangeArray`. Then, I hit 4 existing bugs with new test failures. One is `HTMLEditUtils::LineRequiresPaddingLineBreakToBeVisible`. It checks whether the candidate point to insert a `<br>` is followed by a block boundary first. Then, it checks whether the candidate point follows a collapsible white-space or a block boundary. However, it uses `WSRunScanner::ScanPreviousVisibleNodeOrBlockBoundary()` which ignores invisible white-spaces. Therefore, it will ignore the new invisible white-space and reaches preceding `Text`. Thus, it fails to put a `<br>` and makes the new invisible white-space "fixed" as invisible. Therefore, this patch rewrites the check with using `HTMLEditUtils::GetPreviousLeafContentOrPreviousBlockElement()`. Next one is, `HTMLEditor::DeleteEmptyInclusiveAncestorInlineElements()` returns end of deleted node if it's followed by a non-editable node, i.e., an element has `contenteditable="false"`. Therefore, its caller inserts a `<br>` to the end of the container when deleting preceding editable node of a non-editable node. Therefore, this patch removes the editable state check. Next, `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRange` may put a padding `<br>` after the moved line, but it does not assume that the moved line does not ends with a block boundary. This causes failing #46 and #48 tests in `text_bug772796.html`. E.g., when pressing `Delete` in `<div>foo[]<div><span style="white-space:pre"><div>bar</div>baz</span>`, we move the second `<div>` as a child of the parent `<span>` to end of the first `<div>` like `<div>foo<span style="white-space:pre"><div>bar</div></span></div>...`. Without the change, it starts to put unnecessary `<br>` after ` the `<span>` because of the bug fix in `HTMLEditUtils::LineRequiresPaddingLineBreakToBeVisible` above. This result is completely odd from the users point of view (looks like just move caret), but we should avoid to put the unnecessary `<br>`. Finally, we'll fail an assertion when putting caret at the last of `AutoBlockElementsJoiner::DeleteContentInRange` because it forgets to flush the tracking range before using it. This appeared by the changes above. Therefore, this patch fixes this bug too. Differential Revision: https://phabricator.services.mozilla.com/D240703 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1951518 gecko-commit: 2260ab21bbf0c3e9f7d5eb7cda4fb9300c02be90 gecko-reviewers: m_kato
moz-wptsync-bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
…hich has only a collapsible white-space In bug 1925635, I moved the post processing after deleting ranges in `EditorBase::DeleteRangesWithTransaction` into the `HTMLEditor`'s override. At this time, I makes it uses `HTMLEditUtils::IsEmptyNode` to check whether the `Text` and its containers become empty. Therefore, if `Ctrl`+`Backspace` deletes the only word in the `Text` which starts with a collapsible white-space causes deleting the `Text` after deleting all visible characters in the `Text`. Therefore, this makes check it with `Text::TextDataLength` too before searching the most distant ancestor inline element which becomes empty. However, it may cause leading invisible white-spaces of the only word visible because `nsFrameSelection` computes the word range strictly in the `Text`. Therefore, this patch also makes `HTMLEditor::DeleteRangesWithTransaction` and `AutoDeleteRangesHandler::ComputeRangesToDeleteRangesWithTransaction` extend each range to delete to include surrounding invisible white-spaces too. Therefore, this patch adds the new method to `AutoClonedRangeArray`. Then, I hit 4 existing bugs with new test failures. One is `HTMLEditUtils::LineRequiresPaddingLineBreakToBeVisible`. It checks whether the candidate point to insert a `<br>` is followed by a block boundary first. Then, it checks whether the candidate point follows a collapsible white-space or a block boundary. However, it uses `WSRunScanner::ScanPreviousVisibleNodeOrBlockBoundary()` which ignores invisible white-spaces. Therefore, it will ignore the new invisible white-space and reaches preceding `Text`. Thus, it fails to put a `<br>` and makes the new invisible white-space "fixed" as invisible. Therefore, this patch rewrites the check with using `HTMLEditUtils::GetPreviousLeafContentOrPreviousBlockElement()`. Next one is, `HTMLEditor::DeleteEmptyInclusiveAncestorInlineElements()` returns end of deleted node if it's followed by a non-editable node, i.e., an element has `contenteditable="false"`. Therefore, its caller inserts a `<br>` to the end of the container when deleting preceding editable node of a non-editable node. Therefore, this patch removes the editable state check. Next, `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRange` may put a padding `<br>` after the moved line, but it does not assume that the moved line does not ends with a block boundary. This causes failing #46 and #48 tests in `text_bug772796.html`. E.g., when pressing `Delete` in `<div>foo[]<div><span style="white-space:pre"><div>bar</div>baz</span>`, we move the second `<div>` as a child of the parent `<span>` to end of the first `<div>` like `<div>foo<span style="white-space:pre"><div>bar</div></span></div>...`. Without the change, it starts to put unnecessary `<br>` after ` the `<span>` because of the bug fix in `HTMLEditUtils::LineRequiresPaddingLineBreakToBeVisible` above. This result is completely odd from the users point of view (looks like just move caret), but we should avoid to put the unnecessary `<br>`. Finally, we'll fail an assertion when putting caret at the last of `AutoBlockElementsJoiner::DeleteContentInRange` because it forgets to flush the tracking range before using it. This appeared by the changes above. Therefore, this patch fixes this bug too. Differential Revision: https://phabricator.services.mozilla.com/D240703 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1951518 gecko-commit: 2260ab21bbf0c3e9f7d5eb7cda4fb9300c02be90 gecko-reviewers: m_kato
eq19
pushed a commit
to WeakNegative/wpt
that referenced
this pull request
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.