Make tests for new details styling rules no longer be tentative.#46847
Merged
dbaron merged 1 commit intoweb-platform-tests:masterfrom Jun 26, 2024
Merged
Make tests for new details styling rules no longer be tentative.#46847dbaron merged 1 commit intoweb-platform-tests:masterfrom
dbaron merged 1 commit intoweb-platform-tests:masterfrom
Conversation
This removes the ".tentative" from the filename of tests that are testing the changes specified in whatwg/html#10265 and removes one test (testing that the display property is ignored) that is obsoleted by those changes. (A number of the other tests test what the display property does.)
Member
Author
|
This is intended to be merged at roughly the same time as whatwg/html#10265 |
5 tasks
domenic
approved these changes
Jun 21, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 27, 2024
web-platform-tests/wpt#46847 renamed some tests for details styling to remove "tentative" from the filenames and removed one test. This adjusts the already-existing test expectations for the failures and removes the new ones that the WPT importer added. Fixed: 349655179 Bug: 1469418 Change-Id: I0d4ac2d8a78cfb5a64c516ec4c81f5270d7b3427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5661569 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1320143}
sadym-chromium
pushed a commit
that referenced
this pull request
Jul 18, 2024
) This removes the ".tentative" from the filename of tests that are testing the changes specified in whatwg/html#10265 and removes one test (testing that the display property is ignored) that is obsoleted by those changes. (A number of the other tests test what the display property does.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the ".tentative" from the filename of tests that are testing the changes specified in
whatwg/html#10265 and removes one test (testing that the display property is ignored) that is obsoleted by those changes. (A number of the other tests test what the display property does.)