Payment Request: fix permission policy tests by marcoscaceres · Pull Request #45443 · web-platform-tests/wpt

marcoscaceres · 2024-04-01T04:44:37Z

Cleanup the Permission Policy tests for Payments, and set a substitute URL that works with WebKit's infrastructure.

Fix the tests to use promise_test instead.

wpt-pr-bot · 2024-04-01T04:44:46Z

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

rsolomakhin

Overall looks good! Added a few comments, but they are all for the existing code, not necessarily your patch. It would be great to improve the existing code, but let me know if you think these comments are not relevant.

permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html

permissions-policy/payment-allowed-by-permissions-policy.https.sub.html

permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html

…d echo-PaymentRequest.html https://bugs.webkit.org/show_bug.cgi?id=175611 rdar://125592721 Reviewed by Abrar Rahman Protyasha and Anne van Kesteren. Resync WPT payment-request tests to upstream 1e5aba72c9. The echo-PaymentRequest.html test, along with "allowpayment" and "allowpaymentrequest" directories, were removed from WPT some time ago. The tests also received some updates to fix some issues and better match the spec. So not to lose test coverage for "shipping" related things, imported in the tests from: web-platform-tests/wpt#44409 We will eventually import those from WPT again once that PR is merged and the spec is updated to again include shipping. And bring in Permission Policy fixes from, so we have coverage of the allow attribute: web-platform-tests/wpt#45443 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/payment-request/META.yml: * LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentAddress/w3c-import.log: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentRequestUpdateEvent/constructor.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentRequestUpdateEvent/updatewith-method.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentValidationErrors/w3c-import.log: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/active-document-cross-origin.https.sub-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/active-document-cross-origin.https.sub.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/active-document-same-origin.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/active-document-same-origin.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/allowpaymentrequest-attribute-cross-origin-bc-containers.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/common.sub.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/echo-PaymentRequest.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/no-attribute-cross-origin-bc-containers.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/no-attribute-cross-origin-bc-containers.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/no-attribute-same-origin-bc-containers.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/no-attribute-same-origin-bc-containers.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/removing-allowpaymentrequest.https.sub-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/removing-allowpaymentrequest.https.sub.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/setting-allowpaymentrequest.https.sub-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/setting-allowpaymentrequest.https.sub.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpayment/w3c-import.log: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/basic.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/common.sub.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/echo-PaymentRequest.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/w3c-import.log: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/blank.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/delegate-request.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/payment-request/delegate-request.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/payment-request/historical.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/payment-request/historical.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-is-showing.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-constructor-thcrash.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-constructor.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-ctor-currency-code-checks.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-ctor-pmi-handling.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-ctor-pmi-handling.https.sub.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-disallowed-when-hidden.https-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-disallowed-when-hidden.https.html: Added. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-show-method.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-update-event-constructor.http.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-update-event-constructor.https.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/payment-request/rejects_if_not_active.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/resources/delegate-request-subframe.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/payment-request/resources/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/payment-request/show-consume-activation.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/payment-request/show-consume-activation.https.html: * LayoutTests/imported/w3c/web-platform-tests/payment-request/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-allowed-by-permissions-policy.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html.headers: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-default-permissions-policy.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-default-permissions-policy.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-disabled-by-permissions-policy.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-disabled-by-permissions-policy.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-disabled-by-permissions-policy.https.sub.html.headers: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-supported-by-permissions-policy.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-supported-by-permissions-policy.tentative.html: Added. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * LayoutTests/tests-options.json: Canonical link: https://commits.webkit.org/276932@main

community-tc-integration · 2024-04-02T12:36:00Z

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA/dm8cjkAeQgCIUIEwV2Ca7Q",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA/dm8cjkAeQgCIUIEwV2Ca7Q",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA"
      ]
    }
  ]
}

method: rerunTask
errorCode: InsufficientScopes
statusCode: 403
time: 2024-04-02T12:36:00.234Z

community-tc-integration · 2024-04-02T12:36:03Z

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA/Z6Gc21b2SFWHsvrqgmH9oA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA/Z6Gc21b2SFWHsvrqgmH9oA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/cl38MYbpTRiYVqvhoC4VMA"
      ]
    }
  ]
}

method: rerunTask
errorCode: InsufficientScopes
statusCode: 403
time: 2024-04-02T12:36:03.451Z

wpt-pr-bot added permissions-policy wg-s_webappsec labels Apr 1, 2024

wpt-pr-bot added the status:needs-reviewers label Apr 1, 2024

marcoscaceres requested review from rsolomakhin and stephenmcgruer April 1, 2024 04:44

marcoscaceres mentioned this pull request Apr 1, 2024

[Payment Request] Some imported tests time out because they can't load echo-PaymentRequest.html WebKit/WebKit#26603

Merged

marcoscaceres requested a review from annevk April 1, 2024 04:57

rsolomakhin requested changes Apr 1, 2024

View reviewed changes

wpt-pr-bot assigned marcoscaceres Apr 2, 2024

marcoscaceres requested a review from rsolomakhin April 2, 2024 00:30

rsolomakhin approved these changes Apr 2, 2024

View reviewed changes

marcoscaceres force-pushed the fix_payment_policy_tests branch from 4b5b67b to 207acdc Compare April 8, 2024 06:17

marcoscaceres enabled auto-merge (squash) April 8, 2024 06:17

marcoscaceres added 4 commits April 9, 2024 12:53

Payment Request: fix permission policy tests

0202f3d

Review feedback

a8c6997

Remove unused variabler

c94ebdd

Account for null, which is an object

b78ab08

marcoscaceres force-pushed the fix_payment_policy_tests branch from 207acdc to b78ab08 Compare April 9, 2024 03:07

marcoscaceres merged commit c975e22 into master Apr 9, 2024

marcoscaceres deleted the fix_payment_policy_tests branch April 9, 2024 04:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Payment Request: fix permission policy tests#45443

Payment Request: fix permission policy tests#45443
marcoscaceres merged 4 commits intomasterfrom
fix_payment_policy_tests

marcoscaceres commented Apr 1, 2024

Uh oh!

wpt-pr-bot commented Apr 1, 2024

Uh oh!

rsolomakhin left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

community-tc-integration bot commented Apr 2, 2024

Uh oh!

community-tc-integration bot commented Apr 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

marcoscaceres commented Apr 1, 2024

Uh oh!

wpt-pr-bot commented Apr 1, 2024

Uh oh!

rsolomakhin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

community-tc-integration bot commented Apr 2, 2024

Uh oh!

community-tc-integration bot commented Apr 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants