[Gecko Bug 1884425] Implement interpolation between path() and shape().#45416
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Apr 1, 2024
Merged
[Gecko Bug 1884425] Implement interpolation between path() and shape().#45416moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
Basically, we implement `Animate` for `PathOrShapeFunction` manually when either *from* or *to* value is `path()` function, and the other one is `shape()` function. Differential Revision: https://phabricator.services.mozilla.com/D205491 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1884425 gecko-commit: f166629708eb20fdafe1f49b311466f9d592b6ab gecko-reviewers: firefox-style-system-reviewers, zrhoffman
wpt-pr-bot
approved these changes
Mar 28, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, we implement
AnimateforPathOrShapeFunctionmanuallywhen either from or to value is
path()function, and the other oneis
shape()function.Differential Revision: https://phabricator.services.mozilla.com/D205491
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1884425
gecko-commit: f166629708eb20fdafe1f49b311466f9d592b6ab
gecko-reviewers: firefox-style-system-reviewers, zrhoffman