Page MenuHomePhabricator
Differential D205491

Bug 1884425 - Implement interpolation between path() and shape().
ClosedPublic
Actions

Authored by boris on Mar 22 2024, 7:43 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 30, 5:38 PM
Unknown Object (File)
Tue, Apr 21, 11:49 AM
Unknown Object (File)
Tue, Apr 21, 8:46 AM
Unknown Object (File)
Tue, Apr 21, 7:49 AM
Unknown Object (File)
Tue, Apr 21, 3:18 AM
Unknown Object (File)
Tue, Apr 21, 12:36 AM
Unknown Object (File)
Mon, Apr 20, 7:17 PM
Unknown Object (File)
Oct 16 2025, 3:21 PM
View All 22 Files
Subscribers
emilio
zrhoffman

Details

Reviewers
zrhoffman
Group Reviewers
Restricted Project
Commits
rMOZILLACENTRALf166629708eb: Bug 1884425 - Implement interpolation between path() and shape(). r=firefox…
Bugzilla Bug ID
1884425
Summary

Basically, we implement Animate for PathOrShapeFunction manually
when either *from* or *to* value is path() function, and the other one
is shape() function.

Diff Detail

Event Timeline

boris created this revision.Mar 22 2024, 7:43 PM
Herald added a project: secure-revision. · View Herald TranscriptMar 22 2024, 7:43 PM
Harbormaster completed remote builds in B641950: Diff 840287.Mar 22 2024, 7:43 PM
phab-bot published this revision for review.Mar 22 2024, 7:43 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptMar 22 2024, 7:43 PM
boris updated this revision to Diff 840290.Mar 22 2024, 7:45 PM
Harbormaster completed remote builds in B641953: Diff 840290.Mar 22 2024, 7:45 PM
boris updated this revision to Diff 840322.Mar 22 2024, 8:28 PM
Harbormaster completed remote builds in B641984: Diff 840322.Mar 22 2024, 8:28 PM
boris added reviewers: layout-reviewers, Restricted Project.Mar 22 2024, 8:30 PM
zrhoffman accepted this revision.Mar 25 2024, 5:24 AM
zrhoffman added a project: testing-approved.
zrhoffman added inline comments.
servo/components/style/values/computed/basic_shape.rs
104–111

nit: These &s are not necessary.

122

&s can be removed here, too.

This revision is now accepted and ready to land.Mar 25 2024, 5:24 AM
boris updated this revision to Diff 841612.Mar 26 2024, 6:02 PM
boris marked 2 inline comments as done.

Addressed comments

Harbormaster completed remote builds in B643061: Diff 841612.Mar 26 2024, 6:03 PM
boris updated this revision to Diff 842758.Mar 28 2024, 6:30 PM

Rebaseds

Harbormaster completed remote builds in B644046: Diff 842758.Mar 28 2024, 6:30 PM
boris removed a reviewer: layout-reviewers.Mar 28 2024, 6:33 PM
Closed by commit rMOZILLACENTRALf166629708eb: Bug 1884425 - Implement interpolation between path() and shape(). r=firefox… (authored by boris). · Explain WhyMar 28 2024, 7:48 PM
This revision was automatically updated to reflect the committed changes.
boris added a commit: rMOZILLACENTRALf166629708eb: Bug 1884425 - Implement interpolation between path() and shape(). r=firefox….
Harbormaster completed remote builds in B644255: Diff 842798.Mar 30 2024, 7:24 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
values/
computed/
172 lines95%
Loading...
generics/
24 lines85%
Loading...
testing/
web-platform/
tests/
css/
css-masking/
animations/
114 lines--
clip-path/
animations/
37 lines--
37 lines--
motion/
animation/
104 lines--

Diff 842798

View Options

servo/components/style/values/computed/basic_shape.rs

Loading...
View Options

servo/components/style/values/generics/basic_shape.rs

Loading...
View Options

testing/web-platform/tests/css/css-masking/animations/clip-path-interpolation-shape.html

Loading...
View Options

testing/web-platform/tests/css/css-masking/clip-path/animations/clip-path-shape-interpolation-003.html

Loading...
View Options

testing/web-platform/tests/css/css-masking/clip-path/animations/clip-path-shape-interpolation-004.html

Loading...
View Options

testing/web-platform/tests/css/motion/animation/offset-path-interpolation-008.html

Loading...
Privacy · Cookies · Legal