Implement <selectedoption> for StylableSelect#45096
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 29, 2024
Merged
Implement <selectedoption> for StylableSelect#45096chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
1b88ba1 to
e1b5bc2
Compare
6d87b25 to
eba1277
Compare
This patch adds support for the <selectedoption> element to <select>. The <selectedoption> element replaces its innerHTML with the ancestor <select>'s selected <option>s innerHTML whenever the selected <option> changes. This patch implements it using a SynchronousMutationObserver with an IsDescendantOf check, which might be slow. I added some comments in the header with ideas of how to improve the performance. Bug: 1511354 Change-Id: I38be4657e11dd766cef1fc974e16da173fdf829d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370555 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1280361}
eba1277 to
2eb36c1
Compare
wpt-pr-bot
approved these changes
Mar 29, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
scottaohara
added a commit
to w3c/aria
that referenced
this pull request
Sep 27, 2024
I recreated the [original PR](w3c/html-aam#566) by @josepharhar The `<selectedoption>` element is part of the [customizable select feature](whatwg/html#9799) and is being added to HTML [here](whatwg/html#10633). ## Implementation * WPT tests: web-platform-tests/wpt#45096 * Implementations (link to issue or when done, link to commit): * WebKit: TODO * Gecko: TODO * Blink: https://chromium.googlesource.com/chromium/src/+/18b5eac27b14b409503aa8047cf9358082a0e0df Co-authored-by: Joey Arhar @josepharhar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for the <selectedoption> element to <select>.
The <selectedoption> element replaces its innerHTML with the ancestor
<select>'s selected <option>s innerHTML whenever the selected <option>
changes.
This patch implements it using a SynchronousMutationObserver with an
IsDescendantOf check, which might be slow. I added some comments in the
header with ideas of how to improve the performance.
Bug: 1511354
Change-Id: I38be4657e11dd766cef1fc974e16da173fdf829d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370555
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280361}