[Gecko Bug 1805727] Part 3: Rename all-with-discrete.tentative.html.#44761
Merged
moz-wptsync-bot merged 3 commits intomasterfrom Feb 24, 2024
Merged
[Gecko Bug 1805727] Part 3: Rename all-with-discrete.tentative.html.#44761moz-wptsync-bot merged 3 commits intomasterfrom
moz-wptsync-bot merged 3 commits intomasterfrom
Conversation
Its name doesn't match the current spec because `all` is not a special case for `transition-behavior`. (For more specifically, it uses the obsolete spec definition.) Differential Revision: https://phabricator.services.mozilla.com/D201863 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1805727 gecko-commit: 6b9c12c81a430871fc0f234ae7432c68d31e902a gecko-reviewers: emilio
…imation type. The implementation is straight-forward. We have to check if `transition-behavior` is `allow-discrete` when trying to create a new transition and when checking if we have to cancel a running transition. Also, the test case is out-of-date, so I tweak it a little bit and add more general test cases for transtiion-behavior. Besides, I enable the preference in the WPT folders which use `transition-behavior` (but those tests may be passed already or failed due to reasons other than `transition-behavior`). Differential Revision: https://phabricator.services.mozilla.com/D201864 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1805727 gecko-commit: 9c80651bc3415e25aede25d358bcd0ad6e82c1de gecko-reviewers: emilio
…o discrete. When transition-behavior is allow-discrete, the animation values are transitionable even if they are not interpoltable, given that the animation type of the CSS property is by computed value. Also, we remove `animate()` check from `needs_transitions_update_per_property`. This check was added for handling the transition between `auto` and other values long time ago, but now it may be redundant (because we still pass the tests without it) and we do the same things in nsTransitionManager as well, so it should be fine to drop it, especially after we support discrete transitions. Differential Revision: https://phabricator.services.mozilla.com/D201865 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1805727 gecko-commit: 6203d25d0748a59455054f39056d4e182c4c83c9 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Feb 23, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its name doesn't match the current spec because
allis not a special case fortransition-behavior. (For more specifically, it uses the obsolete specdefinition.)
Differential Revision: https://phabricator.services.mozilla.com/D201863
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1805727
gecko-commit: 6b9c12c81a430871fc0f234ae7432c68d31e902a
gecko-reviewers: emilio