Page MenuHomePhabricator
Differential D201864

Bug 1805727 - Part 4: Implement transition-behavior for properties with discrete animation type.
ClosedPublic
Actions

Authored by boris on Feb 14 2024, 8:22 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 30, 7:12 AM
Unknown Object (File)
Sun, Apr 26, 4:17 PM
Unknown Object (File)
Thu, Apr 23, 7:05 AM
Unknown Object (File)
Mon, Apr 20, 5:25 AM
Unknown Object (File)
Sun, Apr 19, 12:15 PM
Unknown Object (File)
Sun, Apr 19, 10:16 AM
Unknown Object (File)
Sun, Apr 19, 7:56 AM
Unknown Object (File)
Sat, Apr 18, 9:31 PM
View All 44 Files
Subscribers
emilio
zrhoffman

Details

Reviewers
emilio
Commits
rMOZILLACENTRAL9c80651bc341: Bug 1805727 - Part 4: Implement transition-behavior for properties with…
Bugzilla Bug ID
1805727
Summary

The implementation is straight-forward. We have to check
if transition-behavior is allow-discrete when trying to create a new
transition and when checking if we have to cancel a running transition.

Also, the test case is out-of-date, so I tweak it a little bit and add
more general test cases for transtiion-behavior. Besides, I enable the
preference in the WPT folders which use transition-behavior (but
those tests may be passed already or failed due to reasons other than
transition-behavior).

Diff Detail

Event Timeline

boris created this revision.Feb 14 2024, 8:22 PM
Herald added a project: secure-revision. · View Herald TranscriptFeb 14 2024, 8:22 PM
Harbormaster completed remote builds in B628025: Diff 823311.Feb 14 2024, 8:22 PM
boris added a child revision: D201865: Bug 1805727 - Part 5: Support transition-behavior when animation values fall back to discrete..Feb 14 2024, 8:22 PM
phab-bot published this revision for review.Feb 14 2024, 8:22 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptFeb 14 2024, 8:22 PM
boris added reviewers: layout-reviewers, Restricted Project, Restricted Project.Feb 14 2024, 10:06 PM
boris removed a reviewer: Restricted Project.
boris updated this revision to Diff 823623.Feb 15 2024, 3:11 PM

Updated commit message

boris edited the summary of this revision. (Show Details)Feb 15 2024, 3:11 PM
Harbormaster completed remote builds in B628345: Diff 823623.Feb 15 2024, 3:12 PM
emilio requested changes to this revision.Feb 19 2024, 10:24 AM

I think the set might not be needed, but if it is then it needs a comment. Looks good otherwise, thanks!

layout/style/nsTransitionManager.cpp
108

Do we even need this set? We only need this to compare to existing transitions, and if a transition is ongoing the property must have been transitionable?

Or is this needed to handle the case of dynamic switching from transition-behavior: allow-discrete to initial? If so it needs the comment tweaked to say to still be discretely animated or something?

servo/ports/geckolib/glue.rs
1211

s/animationable/animatable

I would've written this as:

if !prop.is_animatable() {
    return false;
}
match behavior { .. }

But fine either way I guess :)

This revision now requires changes to proceed.Feb 19 2024, 10:24 AM
boris updated this revision to Diff 825469.Feb 21 2024, 9:45 PM
boris marked 2 inline comments as done.

Addressed comments

Harbormaster completed remote builds in B629832: Diff 825469.Feb 21 2024, 9:45 PM
boris added inline comments.Feb 21 2024, 9:45 PM
layout/style/nsTransitionManager.cpp
108

Yes, this is the case I was thinking of. However, I tried to add more tests for the case "dynamic switching from transition-behavior: allow-discrete to normal", and it looks like we handle this case well inside ConsiderInitiatingTransition already. So, let's revert this part.

emilio accepted this revision.Feb 23 2024, 9:07 PM
emilio added a project: testing-approved.
This revision is now accepted and ready to land.Feb 23 2024, 9:07 PM
boris removed reviewers: layout-reviewers, Restricted Project.Feb 23 2024, 9:23 PM
boris updated this revision to Diff 826710.Feb 23 2024, 9:24 PM

Addressed comments

Harbormaster completed remote builds in B630858: Diff 826710.Feb 23 2024, 9:24 PM
boris updated this revision to Diff 826744.Feb 23 2024, 9:41 PM

Rebased

Harbormaster completed remote builds in B630879: Diff 826744.Feb 23 2024, 9:41 PM
Closed by commit rMOZILLACENTRAL9c80651bc341: Bug 1805727 - Part 4: Implement transition-behavior for properties with… (authored by boris). · Explain WhyFeb 23 2024, 9:48 PM
This revision was automatically updated to reflect the committed changes.
boris added a commit: rMOZILLACENTRAL9c80651bc341: Bug 1805727 - Part 4: Implement transition-behavior for properties with….
Harbormaster completed remote builds in B631030: Diff 826757.Feb 27 2024, 1:24 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
layout/
style/
5 lines95%
Loading...
1 line75%
Loading...
12 lines94%
Loading...
servo/
components/
style/
values/
specified/
1 line86%
Loading...
ports/
geckolib/
18 lines94%
Loading...
testing/
web-platform/
meta/
css/
CSS2/
floats/
1 line--
css-animations/
2 lines--
css-cascade/
2 lines--
css-contain/
content-visibility/
1 line--
css-position/
2 lines--
css-properties-values-api/
animation/
1 line--
css-transitions/
--
tests/
css/
CSS2/
floats/
15 lines--
css-position/
animations/
29 lines--
css-transitions/
51 lines--

Diff 826757

View Options

layout/style/nsStyleStruct.h

Loading...
View Options

layout/style/nsTransitionManager.h

Loading...
View Options

layout/style/nsTransitionManager.cpp

Loading...
View Options

servo/components/style/values/specified/animation.rs

Loading...
View Options

servo/ports/geckolib/glue.rs

Loading...
View Options

testing/web-platform/meta/css/CSS2/floats/__dir__.ini

Loading...
View Options

testing/web-platform/meta/css/css-animations/__dir__.ini

Loading...
View Options

testing/web-platform/meta/css/css-cascade/__dir__.ini

Loading...
View Options

testing/web-platform/meta/css/css-contain/content-visibility/__dir__.ini

Loading...
View Options

testing/web-platform/meta/css/css-position/__dir__.ini

Loading...
View Options

testing/web-platform/meta/css/css-properties-values-api/animation/__dir__.ini

Loading...
View Options

testing/web-platform/meta/css/css-transitions/transition-behavior.html.ini

Loading...
View Options

testing/web-platform/tests/css/CSS2/floats/float-no-interpolation.html

Loading...
View Options

testing/web-platform/tests/css/css-position/animations/position-interpolation.html

Loading...
View Options

testing/web-platform/tests/css/css-transitions/transition-behaivor.html

Loading...
Privacy · Cookies · Legal