Implement toggle events for dialog elements#44208
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Sep 26, 2024
Merged
Implement toggle events for dialog elements#44208chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
fc086ae to
8b0ca59
Compare
5 tasks
8b0ca59 to
595a592
Compare
595a592 to
a4bacaf
Compare
This patch implements beforetoggle and toggle events for dialog elements. See spec issue: whatwg/html#9733 Bug: 1521813 Change-Id: I56e38230663990c8f1ed8ecd9307a6a881372605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238172 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1360795}
a4bacaf to
e1e1fc1
Compare
wpt-pr-bot
approved these changes
Sep 26, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Nov 5, 2024
This attempts to fix #9733 by specifying that: - A dialog's `show()` steps should dispatch a `beforetoggle` cancellable event. - Followed by a queuing a non-cancellable `toggle` event. - A dialog's `showModal()` steps should dispatch a `beforetoggle` cancellable event. - Followed by a queuing non-cancellable `toggle` event. - The "close the dialog" steps should disaptch a non-cancellable `beforetoggle` event. - Followed by queuing a non-cancellable `toggle` event. Tests: web-platform-tests/wpt#44208.
lozy219
pushed a commit
to lozy219/html
that referenced
this pull request
Mar 10, 2025
This attempts to fix whatwg#9733 by specifying that: - A dialog's `show()` steps should dispatch a `beforetoggle` cancellable event. - Followed by a queuing a non-cancellable `toggle` event. - A dialog's `showModal()` steps should dispatch a `beforetoggle` cancellable event. - Followed by a queuing non-cancellable `toggle` event. - The "close the dialog" steps should disaptch a non-cancellable `beforetoggle` event. - Followed by queuing a non-cancellable `toggle` event. Tests: web-platform-tests/wpt#44208.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements beforetoggle and toggle events for dialog
elements. See spec issue: whatwg/html#9733
Bug: 1521813
Change-Id: I56e38230663990c8f1ed8ecd9307a6a881372605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238172
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk>
Cr-Commit-Position: refs/heads/main@{#1360795}