[WebAuthn] Add tests for cross-origin create() by stephenmcgruer · Pull Request #43729 · web-platform-tests/wpt

stephenmcgruer · 2023-12-19T16:50:37Z

stephenmcgruer · 2023-12-20T16:38:00Z

This test should pass in WPT's Chrome Dev setup once it reaches 122.0.6196.0 (which may not be until after the holidays). It passes locally for me using Chrome Canary. I'm happy to wait until Chrome Dev catches up before landing, if desirable :)

nsatragno

Thanks for the WPT!

webauthn/createcredential-cross-origin-iframe.https.sub.html

webauthn/resources/webauthn-subframe.sub.html

stephenmcgruer · 2024-01-16T18:16:45Z

Results from wpt.fyi - https://wpt.fyi/results/webauthn/createcredential-cross-origin-iframe.https.sub.html?diff&filter=ADC&run_id=5098614518448128&run_id=5186312449032192

stephenmcgruer · 2024-01-16T18:20:38Z

@kenrb if you can take a look in Nina's absence, that would be great thanks!

kenrb

lg although one change might have been missed?

webauthn/createcredential-cross-origin-iframe.https.sub.html

stephenmcgruer · 2024-01-18T15:20:55Z

Thanks Ken! Assigning to @rsolomakhin for LGTM, since looks like Ken maybe isn't a reviewing member of WPT?

community-tc-integration · 2024-01-18T15:31:58Z

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w/fdLXHGJsRnyOiJ6X4vch1g",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w/fdLXHGJsRnyOiJ6X4vch1g",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w"
      ]
    }
  ]
}

method: rerunTask
errorCode: InsufficientScopes
statusCode: 403
time: 2024-01-18T15:31:58.319Z

community-tc-integration · 2024-01-18T15:31:58Z

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w/fmI5mb-CSxWdKAjwXt2wCA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w/fmI5mb-CSxWdKAjwXt2wCA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w"
      ]
    }
  ]
}

method: rerunTask
errorCode: InsufficientScopes
statusCode: 403
time: 2024-01-18T15:31:58.618Z

stephenmcgruer · 2024-01-18T15:32:27Z

The failure from Firefox stability is from the mozilla side:

requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: https://hg.mozilla.org/mozilla-central/archive/tip.zip/testing/profiles/

So I'm going to merge this.

community-tc-integration · 2024-01-18T15:32:58Z

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w/fdLXHGJsRnyOiJ6X4vch1g",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w/fdLXHGJsRnyOiJ6X4vch1g",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/aw_8Vr8FQrC1VpewZElt_w"
      ]
    }
  ]
}

method: rerunTask
errorCode: InsufficientScopes
statusCode: 403
time: 2024-01-18T15:32:58.293Z

See w3c/webauthn#1801

[WebAuthn] Add tests for cross-origin create()

3763cc2

See w3c/webauthn#1801

stephenmcgruer force-pushed the smcgruer/webauthn-cross-origin-tests branch from c5d1e96 to 3763cc2 Compare December 20, 2023 16:32

stephenmcgruer marked this pull request as ready for review December 20, 2023 16:36

wpt-pr-bot added webauthn wg-s_webauthn labels Dec 20, 2023

wpt-pr-bot assigned apowers313 Dec 20, 2023

wpt-pr-bot requested review from apowers313, jcjones and nsatragno December 20, 2023 16:36

nsatragno reviewed Dec 20, 2023

View reviewed changes

stephenmcgruer added 3 commits January 16, 2024 12:41

Address reviwer comments

1796faf

Missed one comment

a1bd094

Fix tab in file

dd94b4e

kenrb reviewed Jan 17, 2024

View reviewed changes

webauthn/createcredential-cross-origin-iframe.https.sub.html Show resolved Hide resolved

Address missed test

a07eccd

stephenmcgruer assigned rsolomakhin Jan 18, 2024

rsolomakhin approved these changes Jan 18, 2024

View reviewed changes

stephenmcgruer enabled auto-merge (squash) January 18, 2024 15:32

stephenmcgruer closed this Jan 18, 2024

auto-merge was automatically disabled January 18, 2024 15:33
Pull request was closed

stephenmcgruer reopened this Jan 18, 2024

stephenmcgruer merged commit d46f1ae into master Jan 18, 2024

stephenmcgruer deleted the smcgruer/webauthn-cross-origin-tests branch January 18, 2024 15:54

marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024

[WebAuthn] Add tests for cross-origin create() (#43729)

b1e1ad9

See w3c/webauthn#1801

Conversation

stephenmcgruer commented Dec 19, 2023

Uh oh!

stephenmcgruer commented Dec 20, 2023

Uh oh!

nsatragno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephenmcgruer commented Jan 16, 2024

Uh oh!

stephenmcgruer commented Jan 16, 2024

Uh oh!

kenrb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stephenmcgruer commented Jan 18, 2024

Uh oh!

community-tc-integration bot commented Jan 18, 2024

Uh oh!

community-tc-integration bot commented Jan 18, 2024

Uh oh!

stephenmcgruer commented Jan 18, 2024

Uh oh!

community-tc-integration bot commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants