Skip to content

[Gecko Bug 1846635] [css-properties-values-api] Support <string> syntax#41308

Merged
foolip merged 1 commit intomasterfrom
gecko/1846635
Jul 30, 2024
Merged

[Gecko Bug 1846635] [css-properties-values-api] Support <string> syntax#41308
foolip merged 1 commit intomasterfrom
gecko/1846635

Conversation

@moz-wptsync-bot
Copy link
Copy Markdown
Collaborator

Differential Revision: https://phabricator.services.mozilla.com/D185203

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846635
gecko-commit: 168ad53da9fdaa993c4f26b252848fb8e76169aa
gecko-reviewers: emilio

Differential Revision: https://phabricator.services.mozilla.com/D185203

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846635
gecko-commit: 168ad53da9fdaa993c4f26b252848fb8e76169aa
gecko-reviewers: emilio
Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@lilles
Copy link
Copy Markdown
Member

lilles commented Aug 3, 2023

There is no spec change landed yet afaik. Also, this changes an interop 2023 test which should formally be approved to be added through an interop github issue.

@lilles lilles self-requested a review August 3, 2023 08:09
Copy link
Copy Markdown
Member

@lilles lilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send a spec PR and raise an interop issue?

@zrhoffman
Copy link
Copy Markdown
Contributor

Send a spec PR

PRed w3c/css-houdini-drafts#1104

and raise an interop issue?

Raised #web-platform-tests/interop#389

zrhoffman added a commit to zrhoffman/wpt that referenced this pull request Dec 20, 2023
…Property

Probably this should not be merged until w3c/css-houdini-drafts#1103 is
resolved/the spec is updated.

Interop bug: web-platform-tests/interop#389

Test coverage for `<string>` syntax in `CSS.registerProperty` is in
web-platform-tests#41308.
@jgraham
Copy link
Copy Markdown
Contributor

jgraham commented Jul 25, 2024

@lilles Can you verify that this is OK to land now?

@foolip foolip merged commit 88fb702 into master Jul 30, 2024
@foolip foolip deleted the gecko/1846635 branch July 30, 2024 08:35
lilles pushed a commit that referenced this pull request Aug 5, 2024
…Property

Probably this should not be merged until w3c/css-houdini-drafts#1103 is
resolved/the spec is updated.

Interop bug: web-platform-tests/interop#389

Test coverage for `<string>` syntax in `CSS.registerProperty` is in
#41308.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 8, 2024
…erage for <string> syntax in @Property, a=testonly

Automatic update from web-platform-tests
[css-properties-values-api] Add test coverage for <string> syntax in @Property

Probably this should not be merged until w3c/css-houdini-drafts#1103 is
resolved/the spec is updated.

Interop bug: web-platform-tests/interop#389

Test coverage for `<string>` syntax in `CSS.registerProperty` is in
web-platform-tests/wpt#41308.

--

wpt-commits: 67cb89fd59b261bfe600534af57324f4621364f5
wpt-pr: 43757
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
…erage for <string> syntax in @Property, a=testonly

Automatic update from web-platform-tests
[css-properties-values-api] Add test coverage for <string> syntax in @Property

Probably this should not be merged until w3c/css-houdini-drafts#1103 is
resolved/the spec is updated.

Interop bug: web-platform-tests/interop#389

Test coverage for `<string>` syntax in `CSS.registerProperty` is in
web-platform-tests/wpt#41308.

--

wpt-commits: 67cb89fd59b261bfe600534af57324f4621364f5
wpt-pr: 43757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants