[wdspec] bidi: print: add tests for content area with less than 1x1 point#40872
Merged
DanielRyanSmith merged 19 commits intomasterfrom Sep 12, 2023
Merged
[wdspec] bidi: print: add tests for content area with less than 1x1 point#40872DanielRyanSmith merged 19 commits intomasterfrom
DanielRyanSmith merged 19 commits intomasterfrom
Conversation
jrandolf-google
approved these changes
Jul 4, 2023
Member
Author
|
Note: Do not submit, wait for review from at least Mozilla folks. |
whimboo
reviewed
Jul 4, 2023
Member
Author
|
Updated test to reflect "unsupported operation", but we still need spec consensus. |
1228882 to
ea9d1f6
Compare
thiagowfx
pushed a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
Jul 10, 2023
thiagowfx
pushed a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
Jul 10, 2023
thiagowfx
pushed a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
Jul 10, 2023
Co-authored-by: Henrik Skupin <mail@hskupin.info>
2d35276 to
28132a8
Compare
thiagowfx
commented
Sep 11, 2023
Member
Author
|
@whimboo PTAL |
thiagowfx
pushed a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
Sep 12, 2023
#1280) …ing an empty content area Related, in sync with, and blocked on: web-platform-tests/wpt#40872
jrandolf-google
approved these changes
Sep 12, 2023
whimboo
approved these changes
Sep 12, 2023
Contributor
whimboo
left a comment
There was a problem hiding this comment.
Thank you for the updates. Looks fine to me. Just two nits that would be good to see addressed before the merge.
Member
Author
|
Done. |
Member
Author
|
@DanielRyanSmith could you admin merge this? |
thiagowfx
pushed a commit
that referenced
this pull request
Sep 12, 2023
…operation for empty content areas Follow-up-of: #40872
thiagowfx
pushed a commit
that referenced
this pull request
Sep 12, 2023
…operation for empty content areas Closes: #40870 Follow-up-of: #40872 Spec: w3c/webdriver-bidi#522
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
…oint (web-platform-tests#40872) * [wdspec] bidi: print: fail gracefully for empty page dimensions Chromium cannot print pages with 0x0 content area. Closes: web-platform-tests#40870 * check for UnsupportedOperationException * Update webdriver/tests/bidi/browsing_context/print/margin.py Co-authored-by: Julian Descottes <jdescottes@mozilla.com> * update test to match spec update Spec: w3c/webdriver-bidi#522 * add new tests for minimum page dimensions with margins * add new tests for invalid small page dimensions * add inch_in_point, replace inch_in_point and inch_in_cm usages * fix typo: page -> margin * add missing pytest fixture * fix indentation error, round up fraction * Update webdriver/tests/bidi/browsing_context/print/margin.py Co-authored-by: Henrik Skupin <mail@hskupin.info> * test: address some review comments * test: address some more review comments * test: add pt_to_cm, fix background test * test: extend test_params_page_invalid_value * make expected_width and expected_height more readable * dimensions: 0.01 -> 0.03 * extract constants for default page width and height * use constant in f-string as well --------- Co-authored-by: Julian Descottes <jdescottes@mozilla.com> Co-authored-by: Henrik Skupin <mail@hskupin.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content area with less than 1x1 point should fail.
Spec: w3c/webdriver-bidi#522
Closes: #40870