WPT: Update IDB WPT helper to avoid duplicate object store creation#38102
Merged
WPT: Update IDB WPT helper to avoid duplicate object store creation#38102
Conversation
wpt-pr-bot
approved these changes
Jan 23, 2023
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
In the WPT that requires creating IDB connection with different version, we should not create the same object store for multiple times. This CL adds a version check to ensure that it's only created when version equals to 1. Bug: 1331187 Change-Id: I4d52cc0e2c56493db5bad59705822c3550fa886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4178503 Reviewed-by: Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1107329}
8b476c7 to
60da07a
Compare
Contributor
These may be pre-existing or newly slow tests. Slow tests indicate that a test ran very close to the test timeout limit and so may become TIMEOUT-flaky in the future. Consider speeding up the test or breaking it into multiple tests. For help, please tag |
Contributor
|
created crbug/1419667, pls help admin merge. @KyleJu @DanielRyanSmith |
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
…38102) In the WPT that requires creating IDB connection with different version, we should not create the same object store for multiple times. This CL adds a version check to ensure that it's only created when version equals to 1. Bug: 1331187 Change-Id: I4d52cc0e2c56493db5bad59705822c3550fa886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4178503 Reviewed-by: Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1107329} Co-authored-by: Mingyu Lei <leimy@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the WPT that requires creating IDB connection with different version,
we should not create the same object store for multiple times. This CL adds
a version check to ensure that it's only created when version equals to 1.
Bug: 1331187
Change-Id: I4d52cc0e2c56493db5bad59705822c3550fa886c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4178503
Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1107329}