Fix the stp downloads: Mac OS Monterey and Mac OS Ventura#34771
Merged
foolip merged 2 commits intoweb-platform-tests:masterfrom Jul 11, 2022
Merged
Fix the stp downloads: Mac OS Monterey and Mac OS Ventura#34771foolip merged 2 commits intoweb-platform-tests:masterfrom
foolip merged 2 commits intoweb-platform-tests:masterfrom
Conversation
- Fix the STP regex to pick up the links for STP.
Why we need this:
When converting to string with text_content, it converts <br> to no space.
For example:
Input: Safari Technology Preview<br>for macOS Ventura
Output: Safari Technology Previewfor macOS Ventura
As a result, the \s+ needs to be changed to \s*
TODO: fix the mac os beta 13.3
Contributor
Author
|
With the changes, STP successfully downloads (logs):
|
foolip
approved these changes
Jul 11, 2022
Member
foolip
left a comment
There was a problem hiding this comment.
Excellent test here, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we need this:
to no space. For example:
Safari Technology Preview<br>for macOS VenturaSafari Technology Previewfor macOS VenturaAs a result, the \s+ needs to be changed to \s*
Fixes #34752