STP downloads are failing #34752
Description
STP downloads have begun failing. https://github.com/web-platform-tests/wpt/runs/7245617686 is a recent example with this log:
./wpt install --channel preview --download-only -d . --rename STP safari browser
INFO:install:Now installing safari browser...
INFO:install:Finding STP download URLs
WARNING:install:Did not find any STP URLs
Traceback (most recent call last):
File "/Users/runner/work/1/s/./wpt", line 10, in <module>
wpt.main()
File "/Users/runner/work/1/s/tools/wpt/wpt.py", line 220, in main
rv = script(*args, **kwargs)
File "/Users/runner/work/1/s/tools/wpt/install.py", line 89, in run
install(browser, kwargs["component"], destination, channel, logger=logger,
File "/Users/runner/work/1/s/tools/wpt/install.py", line 109, in install
path = getattr(browser_cls(logger), method)(dest=destination, channel=channel, **kwargs)
File "/Users/runner/work/1/s/tools/wpt/browser.py", line 1606, in download
image_path = self._download_image(stp_downloads, tmpdir, system_version)
File "/Users/runner/work/1/s/tools/wpt/browser.py", line 1524, in _download_image
raise ValueError(f"no download for {system_version}")
ValueError: no download for 12.4
The error comes from here:
Lines 1516 to 1521 in 36fc6e2
Right now https://developer.apple.com/safari/resources/ says "Requires macOS 12.3 or later" so the problem is that we're matching the version exactly and don't consider this STP for "12.3 or later" a match for macOS 12.4.