[Gecko Bug 1754897] Part 1: Support scroll-timeline-name longhand in style system.#34408
Merged
moz-wptsync-bot merged 4 commits intomasterfrom Jun 14, 2022
Merged
[Gecko Bug 1754897] Part 1: Support scroll-timeline-name longhand in style system.#34408moz-wptsync-bot merged 4 commits intomasterfrom
moz-wptsync-bot merged 4 commits intomasterfrom
Conversation
Implement "scroll-timeline-name: none | <custom-ident>". Differential Revision: https://phabricator.services.mozilla.com/D146018 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1754897 gecko-commit: 783c84b1fe1d08ec2c85f9f39dcbab900778cd1d gecko-reviewers: emilio
Implement "scroll-timeline-axis: block | inline | vertical | horizontal". Differential Revision: https://phabricator.services.mozilla.com/D146019 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1754897 gecko-commit: d545afeeab51038af5c5e5abcda199ce0dba9876 gecko-reviewers: emilio
Implement "scroll-timeline: <'scroll-timeline-axis'> || <'scroll-timeline-name'>". Differential Revision: https://phabricator.services.mozilla.com/D146020 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1754897 gecko-commit: 555e14e928cf360b1c395c0b492034b58e5fc838 gecko-reviewers: emilio
Basically, animation-timeline could be 1. auto 2. none 3. <timeline-name> We extend the <timeline-name> to cover both @scroll-timeline rule and scroll-timeline-name property. We check @scroll-timeline rule first. If it doesn't exist, we check scroll-timeline-name of the element itself, the previous silbings, and their ancestors. Differential Revision: https://phabricator.services.mozilla.com/D146358 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1754897 gecko-commit: b186ae5e163145f05674ac8537f95d71ea7d5543 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jun 13, 2022
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement "scroll-timeline-name: none | ".
Differential Revision: https://phabricator.services.mozilla.com/D146018
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1754897
gecko-commit: 783c84b1fe1d08ec2c85f9f39dcbab900778cd1d
gecko-reviewers: emilio