Details

Reviewers

Group Reviewers

Restricted Project
layout-reviewers

Commits

rMOZILLACENTRAL783c84b1fe1d: Bug 1754897 - Part 1: Support scroll-timeline-name longhand in style system.

Bugzilla Bug ID

1754897

Summary

Implement "scroll-timeline-name: none | <custom-ident>".

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 433087
Build 528613: arc lint + arc unit

Event Timeline

boris created this revision.May 10 2022, 10:55 PM

Herald added a project: secure-revision. · View Herald TranscriptMay 10 2022, 10:55 PM

Harbormaster completed remote builds in B422590: Diff 577529.May 10 2022, 10:55 PM

boris added a child revision: D146019: Bug 1754897 - Part 2: Support scroll-timeline-axis longhand in style system..May 10 2022, 10:55 PM

phab-bot published this revision for review.May 10 2022, 10:55 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: emilio. · View Herald TranscriptMay 10 2022, 10:55 PM

boris updated this revision to Diff 581688.May 21 2022, 12:23 AM

boris edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B425914: Diff 581688.May 21 2022, 12:23 AM

Fixed try failures

Harbormaster completed remote builds in B426371: Diff 582207.May 23 2022, 10:55 PM

Rebased and addressed comments

Harbormaster completed remote builds in B426724: Diff 582683.May 24 2022, 6:46 PM

boris added reviewers: Restricted Project, layout-reviewers.May 24 2022, 10:21 PM

emilio accepted this revision as: emilio.May 25 2022, 8:53 AM

emilio added a project: testing-approved.

This revision is now accepted and ready to land.May 25 2022, 8:53 AM

emilio mentioned this in D146839: Bug 1764126 - Part 4: Add parsing for linear easing function and gate it behind pref. r=emilio.May 25 2022, 9:27 AM

Addressed comments

Harbormaster completed remote builds in B428422: Diff 584782.May 31 2022, 5:03 PM

The analysis task source-test-clang-format failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-clang-external failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Addressed comments

Harbormaster completed remote builds in B430961: Diff 587705.Jun 7 2022, 8:55 PM

Rebased

Harbormaster completed remote builds in B432871: Diff 590050.Jun 13 2022, 6:29 PM

Closed by commit rMOZILLACENTRAL783c84b1fe1d: Bug 1754897 - Part 1: Support scroll-timeline-name longhand in style system. (authored by boris). · Explain WhyJun 13 2022, 8:32 PM

This revision was automatically updated to reflect the committed changes.

boris added a commit: rMOZILLACENTRAL783c84b1fe1d: Bug 1754897 - Part 1: Support scroll-timeline-name longhand in style system..

Harbormaster completed remote builds in B433087: Diff 590096.Sep 26 2022, 5:22 AM

Bug 1754897 - Part 1: Support scroll-timeline-name longhand in style system.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 590096

devtools/server/actors/animation-type-longhand.js

devtools/shared/css/generated/properties-db.js

layout/style/ServoBindings.toml

layout/style/nsStyleStruct.h

layout/style/nsStyleStruct.cpp

layout/style/test/property_database.js

servo/components/style/properties/longhands/ui.mako.rs

servo/components/style/values/computed/box.rs

servo/components/style/values/computed/mod.rs

servo/components/style/values/mod.rs

servo/components/style/values/specified/box.rs

servo/components/style/values/specified/mod.rs

servo/ports/geckolib/cbindgen.toml

testing/web-platform/tests/scroll-animations/css/scroll-timeline-name-computed.tentative.html

testing/web-platform/tests/scroll-animations/css/scroll-timeline-name-parsing.tentative.html

Bug 1754897 - Part 1: Support scroll-timeline-name longhand in style system.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 590096

devtools/server/actors/animation-type-longhand.js

devtools/shared/css/generated/properties-db.js

layout/style/ServoBindings.toml

layout/style/nsStyleStruct.h

layout/style/nsStyleStruct.cpp

layout/style/test/property_database.js

servo/components/style/properties/longhands/ui.mako.rs

servo/components/style/values/computed/box.rs

servo/components/style/values/computed/mod.rs

servo/components/style/values/mod.rs

servo/components/style/values/specified/box.rs

servo/components/style/values/specified/mod.rs

servo/ports/geckolib/cbindgen.toml

testing/web-platform/tests/scroll-animations/css/scroll-timeline-name-computed.tentative.html

testing/web-platform/tests/scroll-animations/css/scroll-timeline-name-parsing.tentative.html

Bug 1754897 - Part 1: Support scroll-timeline-name longhand in style system.
ClosedPublic
Actions

Revision Contents
Changeset List