Test range requests with non-matching range in response#33491
Merged
Conversation
3 tasks
karlt
approved these changes
Apr 7, 2022
| ], 'ok', 'Range response out of range of request'); | ||
| range_rewrite_test([{request: ['0', '*'], status: 200}], 'ok', 'Range requests ignored (200 status)'); | ||
| </script> | ||
| </body No newline at end of file |
Contributor
There was a problem hiding this comment.
Missing closing '>', and I assume convention is to have a newline.
Comment on lines
+22
to
+26
| const ok = new Promise(resolve => | ||
| setInterval(t.step_func(() => { | ||
| if (video.currentTime > 0.1) | ||
| resolve('ok'); | ||
| }, 100))); |
Contributor
There was a problem hiding this comment.
The poll could be avoided by using the "onplay" event, which signals when HAVE_ENOUGH_DATA is reached. That is not reached with 100 bytes.
Something like const ok = new Promise(resolve => video.onplay = () => resolve('ok'));.
Comment on lines
+5
to
+7
| <script src="/common/get-host-info.sub.js"></script> | ||
| <script src="/service-workers/service-worker/resources/test-helpers.sub.js"></script> | ||
| <script src="resources/utils.js"></script> |
Contributor
There was a problem hiding this comment.
These three don't appear to be necessary.
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Apr 27, 2022
…-tests#33491) * Test range requests with non-matching range in response * Put meta before scripts * Use play event instead of polling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.