Pywebsocket refactoring#28667
Pywebsocket refactoring#28667foolip merged 3 commits intoweb-platform-tests:masterfrom arenevier:pywebsocket_refactoring
Conversation
ricea
left a comment
There was a problem hiding this comment.
lgtm
I verified the tools/third_party/pywebsocket3 files are identical to upstream commit 265579a969e1aec2a6457db7674a9e31fbb7d564 .
|
Are the tests failure on windows legitimate failures? I don't have a windows machine. But on linux, I can't reproduce when running |
LukeZielinski
left a comment
There was a problem hiding this comment.
Check failures are unrelated (#28745)
|
@arenevier can you try rebasing? Those CI failures should be resolved now. Also, everyone on this PR might be interested in #28863, which I filed after noticing we're going in an amusing direction :) |
pywebsocket has been refactored to expose some utilities and base class as part of its public API. (see GoogleChromeLabs/pywebsocket3#28) By updating to the newest pywebsocket3 version, we can make ws_h2_handshake much simpler
Done. I have separeted in two commits: first the merge obtained with
Then, the actual changes to wpt. I'm not sure if it would be better to squash them. |
|
In order to preserve the history correctly and make future Right @stephenmcgruer, is that how you've been doing it? |
|
Ping? |
|
@jgraham let me know on IRC that the branch protection rules don't apply to admins, which I can confirm in settings. Makes sense, that's the same reason why admin merging in the UI is allowed. (Force pushing or deleting I'll go ahead and merge this from the command line. |
Automatic update from web-platform-tests Squashed 'tools/third_party/pywebsocket3/' changes from 9db3d29db4..265579a969 265579a969 Expose base.py as a public api. (#28) cdb83e3152 Add missing r to regular expression (#27) git-subtree-dir: tools/third_party/pywebsocket3 git-subtree-split: 265579a969e1aec2a6457db7674a9e31fbb7d564 -- Merge commit '2a247ac52a4af9f82d50b2f96a43abe5c4629ed3' into HEAD -- update ws_h2_handshake.py to recent pywebsocket pywebsocket has been refactored to expose some utilities and base class as part of its public API. (see GoogleChromeLabs/pywebsocket3#28) By updating to the newest pywebsocket3 version, we can make ws_h2_handshake much simpler -- Merge commit 'ec57f8af52fe5e1074ec2de6a5d0d88c4cab257a' Closes web-platform-tests/wpt#28667. -- wpt-commits: 2a247ac52a4af9f82d50b2f96a43abe5c4629ed3, c3c4473d852203e78c4927408aae0b42f95b7385, ec57f8af52fe5e1074ec2de6a5d0d88c4cab257a, 24fa46db564eb4491e9f84edd3d1a07316cc14c6 wpt-pr: 28667
Automatic update from web-platform-tests Squashed 'tools/third_party/pywebsocket3/' changes from 9db3d29db4..265579a969 265579a969 Expose base.py as a public api. (#28) cdb83e3152 Add missing r to regular expression (#27) git-subtree-dir: tools/third_party/pywebsocket3 git-subtree-split: 265579a969e1aec2a6457db7674a9e31fbb7d564 -- Merge commit '2a247ac52a4af9f82d50b2f96a43abe5c4629ed3' into HEAD -- update ws_h2_handshake.py to recent pywebsocket pywebsocket has been refactored to expose some utilities and base class as part of its public API. (see GoogleChromeLabs/pywebsocket3#28) By updating to the newest pywebsocket3 version, we can make ws_h2_handshake much simpler -- Merge commit 'ec57f8af52fe5e1074ec2de6a5d0d88c4cab257a' Closes web-platform-tests/wpt#28667. -- wpt-commits: 2a247ac52a4af9f82d50b2f96a43abe5c4629ed3, c3c4473d852203e78c4927408aae0b42f95b7385, ec57f8af52fe5e1074ec2de6a5d0d88c4cab257a, 24fa46db564eb4491e9f84edd3d1a07316cc14c6 wpt-pr: 28667
No description provided.