Skip to content

move htmloptionscollection to correct place#26

Merged
Ms2ger merged 3 commits intomasterfrom
submissions/opera-htmloptionscollection
Feb 21, 2013
Merged

move htmloptionscollection to correct place#26
Ms2ger merged 3 commits intomasterfrom
submissions/opera-htmloptionscollection

Conversation

@darobin
Copy link
Contributor

@darobin darobin commented Feb 11, 2013

No description provided.

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 12, 2013

The "Add non-option to collection" test is wrong; add() should throw.

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 18, 2013

The spec states:

The namedItem(name) method must return the first node in the collection that has either an id attribute or a name attribute equal to name, if there is one; otherwise, it must return null.

so I believe the following tests are wrong:

  • "namedItem matches multiple IDs"
  • "namedItem matches multiple names"
  • "namedItem matches multiple name and ID"
  • "namedItem matches multiple name and ID with multiple attributes"
  • "namedItem returns a live node list"

Ms2ger added a commit that referenced this pull request Feb 21, 2013
@Ms2ger
Merge pull request #26 from w3c/submissions/opera-htmloptionscollection
46f5b1b 
Move HTMLOptionsCollection tests to the correct place and update them to the spec.
@Ms2ger Ms2ger merged commit 46f5b1b into master Feb 21, 2013
@Ms2ger Ms2ger deleted the submissions/opera-htmloptionscollection branch January 24, 2014 17:57
jgraham added a commit that referenced this pull request Apr 13, 2017
@jgraham
Merge pull request #26 from BruceDai/viewport
3f988ed 
Add view port to tests directory list page for supporting mobile device.
jgraham added a commit that referenced this pull request Apr 21, 2017
@jgraham
Merge pull request #26 from w3c/jgraham/browser_pid
66b77c8 
Make sure that all Browser instances have a pid() method
chromium-wpt-export-bot pushed a commit that referenced this pull request Jul 25, 2025
@thefrog-gh @chromium-wpt-export-bot
Revert "Reland "[FedCM] Adding disconnect to reset test state.""
c79238a 
This reverts commit 11d83f664aba9ed9f977e946c7cd5df8817c955e.

Reason for revert: Causing failing tests detailed in crbug.com/41482163
comments #26, #27, #28.

Bug: 41482163
Original change's description:
> Reland "[FedCM] Adding disconnect to reset test state."
>
> This is a reland of commit 35632c9ba41725c5fabdb14ea66b00af64f83796
>
> Original change's description:
> > [FedCM] Adding disconnect to reset test state.
> >
> > Test results are affected because of previously run tests.
> > Disconnect helps in resetting the test state for each test case.
> >
> > Bug: 41482163
> > Change-Id: Ib97c2ff69ba0d01f886947c0969190c778bb7986
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780242
> > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> > Commit-Queue: Jaimukund Bhan <bhanjaimukund@gmail.com>
> > Reviewed-by: Nicolás Peña <npm@chromium.org>
> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1491540}
>
> Bug: 41482163
> Change-Id: Ib7702a52ea5215993e74ea696d7bbf19a505a98b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6784548
> Commit-Queue: Jaimukund Bhan <bhanjaimukund@gmail.com>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Nicolás Peña <npm@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1491717}

Bug: 41482163
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I6dfb9aa2f05c1ad00f3b12515243c51d6f37632a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788532
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: thefrog <thefrog@chromium.org>
Auto-Submit: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492021}
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 25, 2025
Merged
chromium-wpt-export-bot pushed a commit that referenced this pull request Jul 25, 2025
@thefrog-gh @chromium-wpt-export-bot
Revert "Reland "[FedCM] Adding disconnect to reset test state.""
4d02d18 
This reverts commit 11d83f664aba9ed9f977e946c7cd5df8817c955e.

Reason for revert: Causing failing tests detailed in crbug.com/41482163
comments #26, #27, #28.

Bug: 41482163
Original change's description:
> Reland "[FedCM] Adding disconnect to reset test state."
>
> This is a reland of commit 35632c9ba41725c5fabdb14ea66b00af64f83796
>
> Original change's description:
> > [FedCM] Adding disconnect to reset test state.
> >
> > Test results are affected because of previously run tests.
> > Disconnect helps in resetting the test state for each test case.
> >
> > Bug: 41482163
> > Change-Id: Ib97c2ff69ba0d01f886947c0969190c778bb7986
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780242
> > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> > Commit-Queue: Jaimukund Bhan <bhanjaimukund@gmail.com>
> > Reviewed-by: Nicolás Peña <npm@chromium.org>
> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1491540}
>
> Bug: 41482163
> Change-Id: Ib7702a52ea5215993e74ea696d7bbf19a505a98b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6784548
> Commit-Queue: Jaimukund Bhan <bhanjaimukund@gmail.com>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Nicolás Peña <npm@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1491717}

Bug: 41482163
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I6dfb9aa2f05c1ad00f3b12515243c51d6f37632a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788532
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: thefrog <thefrog@chromium.org>
Auto-Submit: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492021}
foolip pushed a commit that referenced this pull request Aug 13, 2025
@thefrog-gh @foolip
Revert "Reland "[FedCM] Adding disconnect to reset test state.""
fce706f 
This reverts commit 11d83f664aba9ed9f977e946c7cd5df8817c955e.

Reason for revert: Causing failing tests detailed in crbug.com/41482163
comments #26, #27, #28.

Bug: 41482163
Original change's description:
> Reland "[FedCM] Adding disconnect to reset test state."
>
> This is a reland of commit 35632c9ba41725c5fabdb14ea66b00af64f83796
>
> Original change's description:
> > [FedCM] Adding disconnect to reset test state.
> >
> > Test results are affected because of previously run tests.
> > Disconnect helps in resetting the test state for each test case.
> >
> > Bug: 41482163
> > Change-Id: Ib97c2ff69ba0d01f886947c0969190c778bb7986
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780242
> > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> > Commit-Queue: Jaimukund Bhan <bhanjaimukund@gmail.com>
> > Reviewed-by: Nicolás Peña <npm@chromium.org>
> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1491540}
>
> Bug: 41482163
> Change-Id: Ib7702a52ea5215993e74ea696d7bbf19a505a98b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6784548
> Commit-Queue: Jaimukund Bhan <bhanjaimukund@gmail.com>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Nicolás Peña <npm@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1491717}

Bug: 41482163
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I6dfb9aa2f05c1ad00f3b12515243c51d6f37632a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788532
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: thefrog <thefrog@chromium.org>
Auto-Submit: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492021}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

html wg-html

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darobin @Ms2ger