[WPT] Add a #delay-the-load-event test for dynamic imports#25005
Merged
Conversation
wpt-pr-bot
approved these changes
Aug 14, 2020
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
9429274 to
b4bbe12
Compare
b4bbe12 to
e816b19
Compare
e14dfaf to
8061d0e
Compare
Bug: whatwg/html#5824 Change-Id: Ie17cd8d1905b62a28a3699836e5c5f2329f6f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352302 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#1011663}
8061d0e to
37d7f86
Compare
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Mar 11, 2026
For any enabled command, we should fire corresponding beforeinput and input events. Also update a WPT test to make it clearer what the expected behavior is. None of the test expect a beforeinput event. Before, it would fail with "expected undefined, but got", which is not descriptive as a failure to what's happening. We are failing these tests, since this behavior is currently unspecced and also requires changes in the input element to work with text edits. Part of web-platform-tests#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Mar 26, 2026
For any enabled command, we should fire corresponding beforeinput and input events. Also update a WPT test to make it clearer what the expected behavior is. None of the test expect a beforeinput event. Before, it would fail with "expected undefined, but got", which is not descriptive as a failure to what's happening. We are failing these tests, since this behavior is currently unspecced and also requires changes in the input element to work with text edits. Part of web-platform-tests#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
pushed a commit
that referenced
this pull request
Mar 26, 2026
For any enabled command, we should fire corresponding beforeinput and input events. Also update a WPT test to make it clearer what the expected behavior is. None of the test expect a beforeinput event. Before, it would fail with "expected undefined, but got", which is not descriptive as a failure to what's happening. We are failing these tests, since this behavior is currently unspecced and also requires changes in the input element to work with text edits. Part of #25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Apr 21, 2026
With these changes, we now fail the minimum set of tests. That is to say: we don't fail any test that no other browser fails. All test failures therefore match at least 1 other browser. The one exception is the updated test expectation. That's because all browsers fail this test in the exact same way, hence updating the expectation. We fail it, since I don't know how browsers reach to that point. I think it's related to traversal of the contained children and the order that they are traversed in. Unfortunately my attempts at fixing that have not been fruitful, so leaving that one for now. Part of web-platform-tests#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Apr 21, 2026
With these changes, we now fail the minimum set of tests. That is to say: we don't fail any test that no other browser fails. All test failures therefore match at least 1 other browser. The one exception is the updated test expectation. That's because all browsers fail this test in the exact same way, hence updating the expectation. We fail it, since I don't know how browsers reach to that point. I think it's related to traversal of the contained children and the order that they are traversed in. Unfortunately my attempts at fixing that have not been fruitful, so leaving that one for now. Part of web-platform-tests#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Apr 21, 2026
With these changes, we now fail the minimum set of tests. That is to say: we don't fail any test that no other browser fails. All test failures therefore match at least 1 other browser. The one exception is the updated test expectation. That's because all browsers fail this test in the exact same way, hence updating the expectation. We fail it, since I don't know how browsers reach to that point. I think it's related to traversal of the contained children and the order that they are traversed in. Unfortunately my attempts at fixing that have not been fruitful, so leaving that one for now. Part of web-platform-tests#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
pushed a commit
that referenced
this pull request
Apr 21, 2026
With these changes, we now fail the minimum set of tests. That is to say: we don't fail any test that no other browser fails. All test failures therefore match at least 1 other browser. The one exception is the updated test expectation. That's because all browsers fail this test in the exact same way, hence updating the expectation. We fail it, since I don't know how browsers reach to that point. I think it's related to traversal of the contained children and the order that they are traversed in. Unfortunately my attempts at fixing that have not been fruitful, so leaving that one for now. Part of #25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 5, 2026
There is a tricky bit of text nodes that also consider their ancestors effectively contained. To make that properly work, when computing all nodes that are effectively contained, we now traverse from the editing host, rather than the common ancestor container. However, that then would fail numerous tests. That's because when text nodes are moved, their positions would be updated to be the new parent, instead of the original text node. The spec states that this is implicit, but turns out it is not. It might be that this is related to the implementation of ranges in Servo, but for now let's make it explicit it when moving. I also think this is nicer anyways, since we should retain the original selection and that should be the text node. Overall, this makes more tests pass, while also fail others. I will continue investigating why, but unfortunately that's the nature of this suite of WPT tests. Lastly, during debugging I needed to know the exact text contents of these text nodes. Therefore, update the way to format nodes to also consider characterdata, for nicer debugging experience. Part of web-platform-tests#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
jdm
pushed a commit
that referenced
this pull request
May 5, 2026
There is a tricky bit of text nodes that also consider their ancestors effectively contained. To make that properly work, when computing all nodes that are effectively contained, we now traverse from the editing host, rather than the common ancestor container. However, that then would fail numerous tests. That's because when text nodes are moved, their positions would be updated to be the new parent, instead of the original text node. The spec states that this is implicit, but turns out it is not. It might be that this is related to the implementation of ranges in Servo, but for now let's make it explicit it when moving. I also think this is nicer anyways, since we should retain the original selection and that should be the text node. Overall, this makes more tests pass, while also fail others. I will continue investigating why, but unfortunately that's the nature of this suite of WPT tests. Lastly, during debugging I needed to know the exact text contents of these text nodes. Therefore, update the way to format nodes to also consider characterdata, for nicer debugging experience. Part of #25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: whatwg/html#5824
Change-Id: Ie17cd8d1905b62a28a3699836e5c5f2329f6f727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352302
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1011663}