Skip to content

[WPT] Add a #delay-the-load-event test for dynamic imports#25005

Merged
chromium-wpt-export-bot merged 1 commit into
masterfrom
chromium-export-cl-2352302
Jun 7, 2022
Merged

[WPT] Add a #delay-the-load-event test for dynamic imports#25005
chromium-wpt-export-bot merged 1 commit into
masterfrom
chromium-export-cl-2352302

Conversation

@chromium-wpt-export-bot

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 14, 2020

Copy link
Copy Markdown
Collaborator

Bug: whatwg/html#5824
Change-Id: Ie17cd8d1905b62a28a3699836e5c5f2329f6f727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352302
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1011663}

@wpt-pr-bot wpt-pr-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Bug: whatwg/html#5824
Change-Id: Ie17cd8d1905b62a28a3699836e5c5f2329f6f727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352302
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1011663}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2352302 branch from 8061d0e to 37d7f86 Compare June 7, 2022 22:07
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 36749fa into master Jun 7, 2022
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2352302 branch June 7, 2022 23:07
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Mar 11, 2026
For any enabled command, we should fire corresponding
beforeinput and input events.

Also update a WPT test to make it clearer what the
expected behavior is. None of the test expect a
beforeinput event. Before, it would fail with
"expected undefined, but got", which is not descriptive
as a failure to what's happening.

We are failing these tests, since this behavior is
currently unspecced and also requires changes in
the input element to work with text edits.

Part of web-platform-tests#25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Mar 26, 2026
For any enabled command, we should fire corresponding
beforeinput and input events.

Also update a WPT test to make it clearer what the
expected behavior is. None of the test expect a
beforeinput event. Before, it would fail with
"expected undefined, but got", which is not descriptive
as a failure to what's happening.

We are failing these tests, since this behavior is
currently unspecced and also requires changes in
the input element to work with text edits.

Part of web-platform-tests#25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync pushed a commit that referenced this pull request Mar 26, 2026
For any enabled command, we should fire corresponding
beforeinput and input events.

Also update a WPT test to make it clearer what the
expected behavior is. None of the test expect a
beforeinput event. Before, it would fail with
"expected undefined, but got", which is not descriptive
as a failure to what's happening.

We are failing these tests, since this behavior is
currently unspecced and also requires changes in
the input element to work with text edits.

Part of #25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Apr 21, 2026
With these changes, we now fail the minimum set of tests.
That is to say: we don't fail any test that no other browser
fails. All test failures therefore match at least 1 other
browser.

The one exception is the updated test expectation. That's
because all browsers fail this test in the exact same way,
hence updating the expectation. We fail it, since I don't know
how browsers reach to that point. I think it's related to
traversal of the contained children and the order that they
are traversed in. Unfortunately my attempts at fixing that
have not been fruitful, so leaving that one for now.

Part of web-platform-tests#25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Apr 21, 2026
With these changes, we now fail the minimum set of tests.
That is to say: we don't fail any test that no other browser
fails. All test failures therefore match at least 1 other
browser.

The one exception is the updated test expectation. That's
because all browsers fail this test in the exact same way,
hence updating the expectation. We fail it, since I don't know
how browsers reach to that point. I think it's related to
traversal of the contained children and the order that they
are traversed in. Unfortunately my attempts at fixing that
have not been fruitful, so leaving that one for now.

Part of web-platform-tests#25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Apr 21, 2026
With these changes, we now fail the minimum set of tests.
That is to say: we don't fail any test that no other browser
fails. All test failures therefore match at least 1 other
browser.

The one exception is the updated test expectation. That's
because all browsers fail this test in the exact same way,
hence updating the expectation. We fail it, since I don't know
how browsers reach to that point. I think it's related to
traversal of the contained children and the order that they
are traversed in. Unfortunately my attempts at fixing that
have not been fruitful, so leaving that one for now.

Part of web-platform-tests#25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync pushed a commit that referenced this pull request Apr 21, 2026
With these changes, we now fail the minimum set of tests.
That is to say: we don't fail any test that no other browser
fails. All test failures therefore match at least 1 other
browser.

The one exception is the updated test expectation. That's
because all browsers fail this test in the exact same way,
hence updating the expectation. We fail it, since I don't know
how browsers reach to that point. I think it's related to
traversal of the contained children and the order that they
are traversed in. Unfortunately my attempts at fixing that
have not been fruitful, so leaving that one for now.

Part of #25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 5, 2026
There is a tricky bit of text nodes that also consider their ancestors
effectively contained. To make that properly work, when computing all
nodes that are effectively contained, we now traverse from the
editing host, rather than the common ancestor container.

However, that then would fail numerous tests. That's because when
text nodes are moved, their positions would be updated to be the
new parent, instead of the original text node. The spec states that
this is implicit, but turns out it is not. It might be that this is
related to the implementation of ranges in Servo, but for now let's
make it explicit it when moving. I also think this is nicer anyways,
since we should retain the original selection and that should be
the text node.

Overall, this makes more tests pass, while also fail others. I will
continue investigating why, but unfortunately that's the nature of
this suite of WPT tests.

Lastly, during debugging I needed to know the exact text contents of
these text nodes. Therefore, update the way to format nodes to also
consider characterdata, for nicer debugging experience.

Part of web-platform-tests#25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
jdm pushed a commit that referenced this pull request May 5, 2026
There is a tricky bit of text nodes that also consider their ancestors
effectively contained. To make that properly work, when computing all
nodes that are effectively contained, we now traverse from the
editing host, rather than the common ancestor container.

However, that then would fail numerous tests. That's because when
text nodes are moved, their positions would be updated to be the
new parent, instead of the original text node. The spec states that
this is implicit, but turns out it is not. It might be that this is
related to the implementation of ranges in Servo, but for now let's
make it explicit it when moving. I also think this is nicer anyways,
since we should retain the original selection and that should be
the text node.

Overall, this makes more tests pass, while also fail others. I will
continue investigating why, but unfortunately that's the nature of
this suite of WPT tests.

Lastly, during debugging I needed to know the exact text contents of
these text nodes. Therefore, update the way to format nodes to also
consider characterdata, for nicer debugging experience.

Part of #25005

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants