Skip to content

[ci] Emit changes to built website in logs#19952

Merged
gsnedders merged 1 commit intoweb-platform-tests:masterfrom
bocoup:ci-preview-website-diff
Oct 29, 2019
Merged

[ci] Emit changes to built website in logs#19952
gsnedders merged 1 commit intoweb-platform-tests:masterfrom
bocoup:ci-preview-website-diff

Conversation

@jugglinmike
Copy link
Contributor

In gh-19928, we recognized that reviewing changes to the website build process (particularly to the tooling) can be labor-intensive:

@jugglinmike if an update like this would break the docs, would we know
without doing a lot of manual work?

Whether or not the resulting website is still acceptable is harder to say,
but maybe not by that much. By building locally, one could compare the
contents of the _build/html directory for both versions of recommonmark.

That is pretty much what I suspected, a lot of manual work could reveal
problems. Building regression testing is tricky if the output often change in
ways that don't matter to users.

So... I guess we just merge and hope.

This patch exposes that information in the continuous integration logs.

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was literally going to do this.

@gsnedders gsnedders merged commit d151c8a into web-platform-tests:master Oct 29, 2019
@jugglinmike
Copy link
Contributor Author

Right on. Thanks, Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants