Skip to content

Update recommonmark to 0.6.0#19928

Merged
foolip merged 1 commit intomasterfrom
pyup-update-recommonmark-0.5.0-to-0.6.0
Oct 27, 2019
Merged

Update recommonmark to 0.6.0#19928
foolip merged 1 commit intomasterfrom
pyup-update-recommonmark-0.5.0-to-0.6.0

Conversation

@pyup-bot
Copy link
Contributor

@foolip
Copy link
Member

foolip commented Oct 27, 2019

@jugglinmike if an update like this would break the docs, would we know without doing a lot of manual work?

@jugglinmike
Copy link
Contributor

@foolip We know that the build process exits successfully thanks to the GitHub Action which ran for this patch. It reported:

build succeeded.

The HTML pages are in _build/html.

Whether or not the resulting website is still acceptable is harder to say, but maybe not by that much. By building locally, one could compare the contents of the _build/html directory for both versions of recommonmark. There are many kinds of changes that would be acceptable but produce quite a lot of noise in the diff, but there's nothing in the release notes to suggest this will be the case.

@foolip
Copy link
Member

foolip commented Oct 27, 2019

That is pretty much what I suspected, a lot of manual work could reveal problems. Building regression testing is tricky if the output often change in ways that don't matter to users.

So... I guess we just merge and hope.

@foolip foolip merged commit 7acb6b8 into master Oct 27, 2019
@foolip foolip deleted the pyup-update-recommonmark-0.5.0-to-0.6.0 branch October 27, 2019 17:07
@jugglinmike
Copy link
Contributor

@foolip Now that we've merged this, we can review the precise changes to the built contents by taking a look at the commit history of the gh-pages branch, specifically commit 393028a

As we could expect from the aforementioned change log, images now have "alt" text. That's definitely an improvement and likely more in line with what people expect when using the corresponding Markdown syntax. The descriptions are now missing from the body of the guides, though, and I'm not sure if that might actually make it harder for people to use without assistive technology.

In any case, I've opened gh-19952 as a way to surface this information during the review process.

@foolip
Copy link
Member

foolip commented Oct 28, 2019

Thanks Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants