[docs] Use supported syntax highlight name#19403
Merged
foolip merged 1 commit intoweb-platform-tests:masterfrom Oct 1, 2019
Merged
[docs] Use supported syntax highlight name#19403foolip merged 1 commit intoweb-platform-tests:masterfrom
foolip merged 1 commit intoweb-platform-tests:masterfrom
Conversation
A recent addition to the project documentation specifies "svg" as the
desired syntax for a number of examples [1]. However, the package used
to provide syntax highlighting ("pygments" from Python) does not
recognize SVG, so the new examples introduced the following error:
Warning, treated as error:
docs/writing-tests/test-templates.md:55:Pygments lexer name u'svg' is not known
Update the examples to instead request generic XML highlighting.
foolip
approved these changes
Oct 1, 2019
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent addition to the project documentation specifies "svg" as the
desired syntax for a number of examples [1]. However, the package used
to provide syntax highlighting ("pygments" from Python) does not
recognize SVG, so the new examples introduced the following error:
Update the examples to instead request generic XML highlighting.
@heycam @sideshowbarker This failure should have been apparent in gh-19150, but the relevant GitHub Action never ran. I don't know why, but I do know GitHub Actions is still in beta, and we've experienced flakiness before.