Skip to content

Build docs when touching docs/ and select directories in PRs#19303

Merged
jugglinmike merged 2 commits intomasterfrom
foolip/build-docs-prs
Oct 2, 2019
Merged

Build docs when touching docs/ and select directories in PRs#19303
jugglinmike merged 2 commits intomasterfrom
foolip/build-docs-prs

Conversation

@foolip
Copy link
Member

@foolip foolip commented Sep 25, 2019

No description provided.

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip foolip requested a review from jugglinmike September 25, 2019 16:03
@foolip
Copy link
Member Author

foolip commented Sep 25, 2019

The docs building is broken on master now and we should catch it somehow. I used the path filtering to avoid showing it on all PRs, since the list of checks is already quite noisy.

@jugglinmike
Copy link
Contributor

We're currently generating some documentation from files outside of docs/ (and we plan to do still more), so it's possible that a pull request that doesn't touch docs/ could still break the build.

I'm happy to merge this as-is since some visibility is better than no visibility, but I wanted to make sure you were aware of that, first.

@foolip
Copy link
Member Author

foolip commented Oct 1, 2019

Would also depending on tools/ and resources/ be enough right now? As long as the job doesn't trigger on most PRs that just update some tests I think it's fine if it over-triggers in directories that are mostly touched by core maintainers.

@jugglinmike
Copy link
Contributor

Yeah, that sounds good to me!

@foolip foolip changed the title Build docs when modifying docs/ in PRs Build docs when touching docs/ and select directories in PRs Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants